Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

taint warning for Template::Provider #258

Closed
fche opened this issue Mar 27, 2020 · 1 comment · Fixed by #259
Closed

taint warning for Template::Provider #258

fche opened this issue Mar 27, 2020 · 1 comment · Fixed by #259

Comments

@fche
Copy link

fche commented Mar 27, 2020

Observed under bugzilla 5.04, running perl-Template-Toolkit 3.007:

[Fri Mar 27 22:03:49 2020] showdependencytree.cgi: Use of uninitialized value $compiled in concatenation (.) or string at /usr/lib64/perl5/vendor_perl/Template/Provider.pm line 588.
[Fri Mar 27 22:03:49 2020] showdependencytree.cgi: compiled template : Insecure dependency in require while running with -T switch at /usr/lib64/perl5/vendor_perl/Template/Provider.pm line 587.

<LpSolit> _load_compiler() in Template::Provider reports an insecure dependency warning. $fpath must be detained before being passed to require.
@jwakely jwakely mentioned this issue Mar 28, 2020
Merged
@atoomic
Copy link
Collaborator

atoomic commented Mar 30, 2020

Thanks for the fix @jwakely this will be in the coming 3.008 release

atoomic added a commit that referenced this issue Mar 30, 2020
@atoomic
Fix warning in lib/Template/Provider.pm
ae5e01a 
This was introduced when untainting the variable
in #258.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix taint issue in Template/Provider.pm
2 participants
@atoomic @fche