Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

isPaymentSuccess can return undefined property error #6

Closed
phillbrown opened this issue Aug 14, 2013 · 1 comment
Closed

isPaymentSuccess can return undefined property error #6

phillbrown opened this issue Aug 14, 2013 · 1 comment

Comments

@phillbrown
Copy link

In a standard process, isPaymentSuccess is usually called on the notification callback URL and therefore the transaction status will have been set by SagePay. However if we test that transaction endpoint without setting the status, it returns an error: Undefined property: Academe\SagePay\Model\TransactionPdo::$Status

To fix, change line 550 in TransactionAbstract.php to:

if (isset($this->Status) && ($this->Status == 'OK' || $this->Status == 'AUTHENTICATED' || $this->Status == 'REGISTERED')) {
@judgej
Copy link
Member

judgej commented Aug 14, 2013

Thanks. A fix has been pushed to master:

dfe42e1

@judgej judgej closed this as completed Aug 14, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants