-
Notifications
You must be signed in to change notification settings - Fork 144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug]: PNG decoder is not enabled (FFmpeg, Windows) #447
Labels
bug
Something isn't working
Comments
1 task
cedrik-fuoco-adsk
added a commit
that referenced
this issue
Apr 29, 2024
### Enable PNG decoder on Windows ### Linked issues #447 ### Summarize your change. Make sure that FFmpeg knows where to find ZLIB library. ZLIB is needed by the PNG decoder. ZLIB had to be patched to be used during FFmpeg build on Windows. Note that the patch comes from the ZLIB port of Vcpkg. ### Describe the reason for the change. PNG movies were not able to be decoded because PNG decoder in FFmpeg was disabled due to missing ZLIB library during the build of FFmpeg. Since ZLIB is installed by default on MacOS and Linux, it wasn't a problem on those systems. But it means that the wrong ZLIB was used by FFmpeg (not the one compiled by OpenRV). ### Describe what you have tested and on which operating system. - [x] Windows only ### Add a list of changes, and note any that might need special attention during the review. n/a ### If possible, provide screenshots. n/a Signed-off-by: Cédrik Fuoco <cedrik.fuoco@autodesk.com>
Closed by #448 |
cedrik-fuoco-adsk
added a commit
to cedrik-fuoco-adsk/OpenRV
that referenced
this issue
Apr 30, 2024
### Enable PNG decoder on Windows ### Linked issues AcademySoftwareFoundation#447 ### Summarize your change. Make sure that FFmpeg knows where to find ZLIB library. ZLIB is needed by the PNG decoder. ZLIB had to be patched to be used during FFmpeg build on Windows. Note that the patch comes from the ZLIB port of Vcpkg. ### Describe the reason for the change. PNG movies were not able to be decoded because PNG decoder in FFmpeg was disabled due to missing ZLIB library during the build of FFmpeg. Since ZLIB is installed by default on MacOS and Linux, it wasn't a problem on those systems. But it means that the wrong ZLIB was used by FFmpeg (not the one compiled by OpenRV). ### Describe what you have tested and on which operating system. - [x] Windows only ### Add a list of changes, and note any that might need special attention during the review. n/a ### If possible, provide screenshots. n/a Signed-off-by: Cédrik Fuoco <cedrik.fuoco@autodesk.com> Signed-off-by: Cédrik Fuoco <cedrik.fuoco@autodesk.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
What happened?
PNG movies can not be decoder because the PNG decoder is not enabled on Windows.
PNG decoder is disabled on Windows because ZLIB is not found by FFmpeg.
List all the operating systems versions where this is happening
Windows
On what computer hardware is this happening?
Windows
Relevant console log output
ERROR: MovieFFMpeg: Unsupported codec_id '61'
Environment variables
No response
Extra information
No response
Code of Conduct
The text was updated successfully, but these errors were encountered: