changes to ipvs checkers #181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
New tcp check config option "retry" sets the check retry counter. If tcp check fails on an alive server, keepalived will perform another checks until n_retry counter reaches zero, or until the check succeeds. The delay between retry checks is configured by the "delay_before_retry" config option. The default value is 1 retry after 1 second. This is the same feature that already exists in HTTP checker (config option "nb_get_retry").
Retry on every error, including timeout and connection error, but only when RS is up. This is needed to reduce rs flaps: we shut the server down only after nb_get_retry failed checks. Also, do not wait for delay_loop after a successfull check to bring the server UP.
Previously, if the IPVS reflector was unable to perform its task, it reported error through syslog and ignored it. This behavior leads to inconsistancies with quorum-handler: it is called with UP even if no RS were added into the IPVS. This could take place, for example, when there is a limit of opened filehandles and keepalived was unable to open netlink socket (it is opened on every call to the ipvs_talk). Now the check is not marked as OK unless IPVS reflector reports OK. Following successfull check will try to add an RS again. The special case errors "ENOENT on remove" and "EEXIST on add" are treated with OK result code.
These functions are turned from int into void: ipvs_group_sync_entry, ipvs_group_remove_entry, ipvs_syncd_cmd.
do MD5 calculation only when configured to do so
timer_cmp is called too often and eats much of cpu cycles. Make the comparison more effective. Increase code re-using in monotonic_gettimeofday(). Use timer_reset_lazy() where possible to omit the excess memset() call.
Since threads are sorted by t->sands, we could break the cycle when not expired thread found.
Do not remove and re-add a real_server when reloading config if its weight has changed. Just edit the existing ipvs rs entry.
This option explicitly specifies the address family of a fwmark IPVS service entry. Previously it was determined by the AF of the first real server. This logic is kept as a fallback when the "ip_family" option is missing. Also, now it is possible to create two different services for v4 and v6 with the same fwmark number.
azryve
pushed a commit
to azryve/keepalived
that referenced
this pull request
Nov 29, 2016
changes to ipvs checkers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, Alexandre.
Please consider these changes: