[289509] Implement parameter validation #272

Double-oxygeN · 2024-06-25T01:54:52Z

https://acsmine.tok.access-company.com/redmine/issues/289509

…ult/0`

…tions

…ous functions" This reverts commit f08bc95.

lib/type/base_param_struct.ex

lib/type/body_json_list.ex

lib/type/base_param_struct.ex

lib/type/body_json_list.ex

lib/type/base_param_struct.ex

lib/type/body_json_list.ex

lib/type/body_json_struct.ex

lib/web/plug/params_validator.ex

core/type/base_param_struct.ex

lib/web/plug/params_validator.ex

core/type/base_param_struct.ex

Co-authored-by: Yuki Sekiguchi <yuki.sekiguchi@access-company.com>

lib/type/param_string_struct.ex

core/type/base_param_struct.ex

…nerate/1`

aYukiSekiguchi

LGTM

core/type/base_param_struct.ex

lib/type/param_string_struct.ex

Double-oxygeN added 16 commits June 21, 2024 19:01

[289509] Implement BaseParamStruct

7530c57

[289509] Implement Antikythera.BodyJsonStruct

f533799

[280509] Implement Antikythera.ParamStringStruct

4e4ee7b

[289509] Refactor

cb9e297

[289509] Implement Antikythera.Plug.ParamsValidator.validate/2

1e65957

[289509] Implement BodyJsonList and BodyJsonMap

9a579e4

[289509] Use default value if the module of a missing field has `defa…

925741b

…ult/0`

[289509] Fix from_params/1

0552b36

[289509] Refactor Antikythera.BaseParamStruct

6dde765

[289509] Add support of :accept_case option

c136a10

[289509] Add support of :default option

e77010f

[289509] Write documentations

870a784

[289509] Add "Exported functions" sections

ceef040

[289509] Refactor base_param_struct.ex

080fc60

[289509] Fix: implicit preprocessors can be defined as anonymous func…

f08bc95

…tions

Revert "[289509] Fix: implicit preprocessors can be defined as anonym…

91f7d22

…ous functions" This reverts commit f08bc95.

aYukiSekiguchi reviewed Jun 26, 2024

View reviewed changes

Double-oxygeN added 13 commits June 26, 2024 17:22

[289509] Add more description about the limitation of module attributes

2a2b1ff

[289509] Wrap by v[] as much as possible

73d6d6f

[289509] Move BaseParamStruct to AntikytheraCore

659deeb

[289509] Use alias for Croma.Result

8e72700

[289509] Add BaseParamStruct.attach_attributes_to_field/3

0e9dea2

[289509] Use Map.new/1 instead of Enum.into/2

99a36cb

[289509] Fix type annotations

e5c39dd

[289509] Rename guards

d983a98

[289509] Fix: JSON objects → JSON values

e739bec

[289509] Default preprocessor is fixed to &Function.identity/1

cafa89d

[289509] Add AntikytheraCore.BodyJsonCommon

842bcc5

[289509] Fix docs

bf5ee47

[289509] Move test code file

a85f5eb

Double-oxygeN added 2 commits June 28, 2024 17:39

[289509] Fix tests

d456650

[289509] Add explanation about validation error handling

4140383

Double-oxygeN requested a review from aYukiSekiguchi July 2, 2024 01:06

aYukiSekiguchi reviewed Jul 3, 2024

View reviewed changes

Double-oxygeN and others added 5 commits July 3, 2024 17:17

[289509] Make BaseParamStruct docs simpler

413a07c

Co-authored-by: Yuki Sekiguchi <yuki.sekiguchi@access-company.com>

[289509] Rename to :preprocessor_generator

d3b77bb

[289509] Omit key argument from BaseParamStruct.fetch_from_dict

92da097

[289509] Fix docs about how to get the validated params

f4a5ac1

[289509] Refactor preprocess_params

b81530d

aYukiSekiguchi reviewed Jul 3, 2024

View reviewed changes

lib/type/param_string_struct.ex Outdated Show resolved Hide resolved

core/type/base_param_struct.ex Outdated Show resolved Hide resolved

Double-oxygeN added 4 commits July 4, 2024 12:07

[289509] Add Antikythera.StringPreprocessor

88c9f5e

[289509] Rename Preprocessor.default/1 to `PreprocessorGenerator.ge…

a676746

…nerate/1`

[289509] Hide AntikytheraCore.BodyJsonCommon.PreprocessorGenerator

2a4c8db

[289509] Fix types

65a1f2a

aYukiSekiguchi approved these changes Jul 4, 2024

View reviewed changes

core/type/base_param_struct.ex Outdated Show resolved Hide resolved

lib/type/param_string_struct.ex Outdated Show resolved Hide resolved

Double-oxygeN added 2 commits July 4, 2024 15:45

[289509] Rename to get_default_value_from_module

f69e267

[289509] Make some functions private

e61e49b

Double-oxygeN merged commit d025703 into master Jul 5, 2024
7 checks passed

Double-oxygeN deleted the 289509_parameter_validation branch July 5, 2024 01:04

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[289509] Implement parameter validation #272

[289509] Implement parameter validation #272

Double-oxygeN commented Jun 25, 2024

aYukiSekiguchi left a comment

[289509] Implement parameter validation #272

[289509] Implement parameter validation #272

Conversation

Double-oxygeN commented Jun 25, 2024

aYukiSekiguchi left a comment

Choose a reason for hiding this comment