[Build] Failing builds due to network timeouts on model loading

[K-Kumar-01]

Bug Report 🐛

Currently the build fails many times when a PR is made. A re-run is required many a times for this to pass successfully. The failure is due to this line.
It involves fetching model but since azure(where the models are hosted) is inconsistent, we face the error.

Expected Behavior

The build shoud pass.

Current Behavior

The build fails,

Possible Solution

Passing an offline:true flag to options will ensure the pass.

Steps to Reproduce

1. Make a PR.
2. The build might fail with the error that it was not able to download the model.

Context (Environment)

Desktop

• OS: Windows, Ubuntu
• Browser: Chrome

Detailed Description

Passing offline:true will make the build pass.

[algomaster99]

@dselman @K-Kumar-01 The change is required for more test cases than expected. You can see the latest build on master is failing.

[K-Kumar-01]

@algomaster99
I think we would need to pass the offline: true option in all the instances where loadModelManger is used.

[algomaster99]

Right

[K-Kumar-01]

@dselman
const modelManager = await ModelLoader.loadModelManager([modelFilePath]);
Here, the third argument is the options one.
Could you tell about second argument.

I want to understand how to pass the third argument without passing the second argument/ passing the appropriate second argument.
Thanks in advance:)

[dselman]

The options are the second argument, so you should use {offline: true} as the second argument.

Method definition:
https://github.com/accordproject/concerto/blob/master/packages/concerto-core/lib/modelloader.js#L64

[jeromesimeon]

There is an issue!! @K-Kumar-01

I still see sometimes failing tests in markdown-cli and markdown-transform but the fix in #445 should already help. I'll report when I'm done with the other packages.