Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(markdown-template): Build failure - #422 #423

Merged
merged 1 commit into from Jul 2, 2021

Conversation

K-Kumar-01
Copy link
Collaborator

Pass offline:true in loadModelManager

Signed-off-by: K-Kumar-01 kushalkumargupta4@gmail.com

Closes #422

Changes

  • Pass offline:true in options in loadModelManager

Author Checklist

  • Ensure you provide a DCO sign-off for your commits using the --signoff option of git commit.
  • Vital features and changes captured in unit and/or integration tests
  • Commits messages follow AP format
  • Extend the documentation, if necessary
  • Merging to master from fork:branchname

Pass offline:true in loadModelManager

Signed-off-by: K-Kumar-01 <kushalkumargupta4@gmail.com>
@algomaster99
Copy link
Member

@K-Kumar-01 I would recommend you to explain why you have made this change so that the reviewer can understand the change's need.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 87.57% when pulling 57727a2 on k-kumar-01/i422/failing-build into f861c6e on master.

Copy link
Member

@algomaster99 algomaster99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

The tests often failed because of the inconsistency of GitHub actions to fetch external models required for test case markdown-template/TemplateMarkTransformer. The change runs these tests in offline mode so that fetching such dependencies is no longer needed. Thus, eliminating the inconsistency persisting in Azure (where the GitHub actions are executed).

@dselman dselman merged commit 4a4b3c7 into master Jul 2, 2021
@dselman dselman deleted the k-kumar-01/i422/failing-build branch July 2, 2021 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Build] Failing builds due to network timeouts on model loading
4 participants