Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: mongodb 5 compatability in all mongo password methods #1220

Merged
merged 2 commits into from
May 19, 2022
Merged

fix: mongodb 5 compatability in all mongo password methods #1220

merged 2 commits into from
May 19, 2022

Conversation

abhishekk-raj
Copy link
Contributor

Fix for issue #1219

@changeset-bot
Copy link

changeset-bot bot commented May 18, 2022

🦋 Changeset detected

Latest commit: cfc13a3

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@accounts/mongo-password Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codecov
Copy link

codecov bot commented May 19, 2022

Codecov Report

Merging #1220 (cfc13a3) into master (79575f8) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #1220      +/-   ##
==========================================
+ Coverage   95.29%   95.31%   +0.01%     
==========================================
  Files         106      106              
  Lines        2381     2391      +10     
  Branches      492      511      +19     
==========================================
+ Hits         2269     2279      +10     
  Misses        103      103              
  Partials        9        9              
Impacted Files Coverage Δ
...ages/database-mongo-password/src/mongo-password.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 79575f8...cfc13a3. Read the comment docs.

@pradel
Copy link
Member

pradel commented May 19, 2022

@abhishekk-raj could please add a changeset to the pr? Otherwise LGTM 🚀

@pradel pradel merged commit fb49d62 into accounts-js:master May 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants