Upgrade to React 0.14.0 #3
Conversation
jdlehman
commented
Oct 10, 2015
jdlehman
commented
- This aims to provide support for React 0.14.0 and get rid of the deprecation warning mentioned in Issue Update to support React 0.14 #2
|
This is a start to getting everything working properly with 0.14.0. I was able to get all the deprecation warnings out of the tests and onto the latest version of redux, but I did not get the tests passing yet. Feel free to take a look and provide feedback on this progress and I will take another stab at getting the tests passing tomorrow. |
jdlehman
force-pushed
the
upgrade-react
branch
from
407564c
to
d978237
Compare
|
Went back and made the first commit simply upgrade React to 0.14.0 and things that did not necessitate changing the tests. Everything passes but there are still deprecation warnings, so I will get rid of those and this will be ready to go. |
jdlehman
force-pushed
the
upgrade-react
branch
from
8f0818f
to
ed9dfe8
Compare
|
Take two on getting the tests passing without deprecations: All the deprecations are gone from the tests, but the This PR gets us most of the way there, but a second pair of eyes would be great to help me find the flaw in my test refactor logic. |
| } | ||
| } | ||
| const ConnectedComponent = connect(state => { | ||
| return { todos: state.todos, f: () => {} }; |
There was a problem hiding this comment.
I think the test failure has something to do with using the new connect function rather than the Connector component.
If the function f is included in the returned state, the case without batchedUpdates passes and the one with fails. Removing f from the returned state reverses this such that the batchedUpdates case passes and the case without fails.
|
👍 |
|
ping @acdlite |
|
@jdlehman maybe you could publish your fork on npm meanwhile? |
|
@nickdima you can point to my branch with npm if you'd like to use it: That said if you are concerned about performance, the update in redux 3.0.3 helps (though it doesn't replace the batched updates). |
|
I'd recommend using https://github.com/tappleby/redux-batched-subscribe, which supports React 0.14 |
|
great, thanks @rickharrison |
