Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add interaction to inventory holders #6029

Merged
merged 39 commits into from
Jul 10, 2023

Conversation

Dystopian
Copy link
Contributor

@Dystopian Dystopian commented Jan 6, 2018

When merged this pull request will:

  • add Inventory interaction to inventory holders: dead bodies and dropped weapons/gear;
  • add Inventory interaction to unconscious men;
  • add Drag/Carry actions to dropped gear and Carry to dead body weapons;
  • reformat and optimize ace_dragging_fnc_canCarry and ace_dragging_fnc_canDrag.

Now it's much easier to take gear from several bodies/weapons lying close to each other.

TODO:

  • take weapon/mag
  • adjust action position
  • drag/carry
  • cargo load
  • setting to disable ?

WIP

@Dystopian
Copy link
Contributor Author

Dystopian commented Jan 9, 2018

Unfortunately dropped from dead body weapons (class WeaponHolderSimulated) are bad when drag/carry: they can just disappear (looks like they go far under ground), so I had to enable drag menu for dropped gear only.

BTW possibility to take weapon from unconscious enemy is amazing ;)

@Dystopian
Copy link
Contributor Author

Dead body weapons can be carried now (with small workaround).
Cargo loading and moving gear to another vehicle gear have too many troubles to fix so I decided not implement them.

This is done, please review.

@654wak654
Copy link
Contributor

Moving towards a future without the action menu, one PR at a time 👍

@jonpas jonpas added the kind/feature Release Notes: **ADDED:** label Jan 22, 2018
@jonpas jonpas added this to the 3.13.0 milestone Jan 22, 2018
Copy link
Member

@jonpas jonpas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just took a brief look at it, seems a very short solution for what it does! 👍

@Dystopian Dystopian mentioned this pull request Nov 6, 2018
@severgun
Copy link
Contributor

severgun commented Nov 7, 2018

Moving whole weaponholder seems weird for me and far from "realism" theme of ACE3 mod.
You can drop tonns of ammo on a ground and then carry it around in hands.

@dedmen
Copy link
Contributor

dedmen commented Nov 7, 2018

^ I agree. Also picking up a invisible force matrix that holds the items together seems.. Not right.
I can see it looking acceptable for a single weapon. But even then you might aswell just pick it up.

Also the last couple games I played I tried several times to find the "open inventory" action on a dead body and wondered why I couldn't find it. Completely forgot that this isn't merged and released already.

@Dystopian
Copy link
Contributor Author

@severgun you can't drop tonns of ammo on a ground and then carry it

@dedmen I think I do can hold some magazines and weapons in hands. I think this is not really big difference from other objects carrying.

@dedmen
Copy link
Contributor

dedmen commented Nov 7, 2018

you can't drop tonns of ammo on a ground and then carry it

What prevents you from doing that?

@Dystopian
Copy link
Contributor Author

@dedmen
Copy link
Contributor

dedmen commented Nov 7, 2018

So.. Nothing does?
You still can carry as much as with boxes, just without the box now then.
Hm. Okey.

@10Dozen
Copy link
Contributor

10Dozen commented Jul 23, 2021

Is it possible to allow player to run when e.g. only 2 items are in hands and total weight is about <=10-15 kg? Like - to pick 2 AT-4 from truck and run back to positions, instead of walking/finding big backpack. Stamina drain may be at the same level, as it's harder to keep balance.

@Dystopian
Copy link
Contributor Author

Is it possible to allow player to run when e.g. only 2 items are in hands and total weight is about <=10-15 kg?

I will try to implement this in other PR.

@LinkIsGrim
Copy link
Contributor

Works, including MP. Functionality and performance are fine, but see Dystopian#2 for code suggestions.

Also, there's a double-up when using this with disarming:
107410_20230707070742_1

But that should be fixed after merging.

@LinkIsGrim LinkIsGrim modified the milestones: Ongoing, 3.16.0 Jul 9, 2023
@LinkIsGrim LinkIsGrim merged commit 1b8c56f into acemod:master Jul 10, 2023
5 checks passed
@Dystopian Dystopian deleted the inventory_interaction branch July 10, 2023 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Release Notes: **ADDED:**
Projects
None yet
Development

Successfully merging this pull request may close these issues.