CSW/Mk6 Mortar - Make Mk6 Mortar Ammo Handling override CSW's #9238
Conversation
LinkIsGrim
changed the title
| // If magazine handling is enabled or weapon assembly/disassembly is enabled we enable ammo handling | ||
| if ((GVAR(ammoHandling) == 0) && {!([false, true, true, GVAR(defaultAssemblyMode)] select (_target getVariable [QGVAR(assemblyMode), 3]))}) exitWith { false }; | ||
| // If magazine handling and weapon assembly/disassembly are enabled we enable ammo handling | ||
| if ((GVAR(ammoHandling) == 0) || {!([false, true, true, GVAR(defaultAssemblyMode)] select (_target getVariable [QGVAR(assemblyMode), 3]))}) exitWith { false }; |
There was a problem hiding this comment.
I'm not sure about this,
before even if ammoHandling was off you could still always load a "CSW" static weapon
e.g. if you assemble a csw from 2 carried weapons then it would still be loadable
because otherwise you just have a empty weapon that you can't do anything with
There was a problem hiding this comment.
I'll figure something out. Though you might agree that ammo handling still being possible despite the setting is confusing.
There was a problem hiding this comment.
yeah I'd probably say it's mission-maker error
but docs also say
### 3.3 ammoHandling
- Whether or not you want to handle ammo using the CSW way. Does nothing if using defaultAssemblyMode
- Default: On
There was a problem hiding this comment.
IMO it shouldn't even be an option. This feature makes no sense without ammo handling.
There was a problem hiding this comment.
I think we should revert it to the previous behaviour, despite the setting being confusing.
There was a problem hiding this comment.
Can you split off the changes not related to this specific PR into a separate one?
| // If magazine handling is enabled or weapon assembly/disassembly is enabled we enable ammo handling | ||
| if ((GVAR(ammoHandling) == 0) && {!([false, true, true, GVAR(defaultAssemblyMode)] select (_target getVariable [QGVAR(assemblyMode), 3]))}) exitWith { false }; | ||
| // If magazine handling and weapon assembly/disassembly are enabled we enable ammo handling | ||
| if ((GVAR(ammoHandling) == 0) || {!([false, true, true, GVAR(defaultAssemblyMode)] select (_target getVariable [QGVAR(assemblyMode), 3]))}) exitWith { false }; |
There was a problem hiding this comment.
This check should be moved to line 72 imo: We don't add/move interactions if they shouldn't be enabled.
When merged this pull request will:
Partially addresses #8866 and #7477.
IMPORTANT
Component - Add|Fix|Improve|Change|Make|Remove {changes}.