-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Doc Repo second round testing #4702
Comments
Yeah this is a feature that doesn't exist (rather than something not working correctly). A category is just a tag in the DB for presenting the fold/unfold view in the browser. All files are just uploaded to So you're right, item 11 needs to be updated as that's not actually something LORIS does. |
@johnsaigle true! that makes sense .. i'll update the test plan |
It looks like for 9. that the download is actually serving the content of the webpage rather than the file it should be downloading. As in it downloads the HTML of LORIS as My guess is that it could be due to the path e.g. |
@johnsaigle yeah i've been trying to figure this one out but not sure. if you want to have a crack at it let me know! FYI i'm fixing the errors in my error_log from testing the download just so we don't have fixing duplication (a PR will be coming soon) |
Yeah I probably won't do anymore on this today but I'll get back to you if I do in the coming days |
Fixes part of #4702. In particular: 5. Undefined index php notices in error log 8. Pointer cursor can be added for 'Delete' 13. test plan probably needs updating
Can you split the remaining things into multiple tickets and close this? |
leftover issues separated into individual issues |
Fixes part of aces#4702. In particular: 5. Undefined index php notices in error log 8. Pointer cursor can be added for 'Delete' 13. test plan probably needs updating
They also cannot be edited or added (this was never a feature). Comments should appear as tooltipfixed issues:
1. Can create duplicate category names3. front-end errors in Browse tab - PR #4701 merged4. files don't get saved in proper directory - PR #4466 merged5.Undefined index
php notices in error log - PR #4721 merged8. Pointer cursor can be added for 'Delete' - PR #4721 merged11. not able to upload files with same name in different categories12. No 'date uploaded' date - PR #472513. test plan probably needs updating - PR #4721 mergedThe text was updated successfully, but these errors were encountered: