Doc Repo second round testing

[zaliqarosli]

1. When error thrown on trying to upload duplicate file name, form data gets erased and it shouldnt?
2. Newly created subcategory does not appear in parent category directory on front-end as long as the parent category does not contain files
3. Comments do not appear for a category. They also cannot be edited or added (this was never a feature). Comments should appear as tooltip
4. Downloading content does not work - @johnsaigle
5. New uploaded file does not appear until refresh

fixed issues:
1. Can create duplicate category names
3. front-end errors in Browse tab - PR #4701 merged
4. files don't get saved in proper directory - PR #4466 merged
5. Undefined index php notices in error log - PR #4721 merged
8. Pointer cursor can be added for 'Delete' - PR #4721 merged
11. not able to upload files with same name in different categories
12. No 'date uploaded' date - PR #4725
13. test plan probably needs updating - PR #4721 merged

[johnsaigle]

11. not able to upload files with same name in different categories

Yeah this is a feature that doesn't exist (rather than something not working correctly). A category is just a tag in the DB for presenting the fold/unfold view in the browser. All files are just uploaded to .../modules/document_repository/user_uploads/$user/$filename. That's why there's a conflict.

So you're right, item 11 needs to be updated as that's not actually something LORIS does.

[zaliqarosli]

@johnsaigle true! that makes sense .. i'll update the test plan

[johnsaigle]

It looks like for 9. that the download is actually serving the content of the webpage rather than the file it should be downloading. As in it downloads the HTML of LORIS as photo.jpg instead of the photo.

My guess is that it could be due to the path e.g. https://jsaigle-dev.loris.ca/document_repository/Files/bread-food-healthy-breakfast.jpg. I think Files/ is wrong there unless there's some new routing I don't know about.

[zaliqarosli]

@johnsaigle yeah i've been trying to figure this one out but not sure. if you want to have a crack at it let me know! FYI i'm fixing the errors in my error_log from testing the download just so we don't have fixing duplication (a PR will be coming soon)

[johnsaigle]

Yeah I probably won't do anymore on this today but I'll get back to you if I do in the coming days

[driusan]

Can you split the remaining things into multiple tickets and close this?

[zaliqarosli]

leftover issues separated into individual issues