Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MRI Violations] No Series UID column #5419

Closed
johnsaigle opened this issue Oct 30, 2019 · 3 comments
Closed

[MRI Violations] No Series UID column #5419

johnsaigle opened this issue Oct 30, 2019 · 3 comments
Assignees
@cmadjar
Labels
Bug PR or issue introducing/requiring bug fixes (not mutually exclusive with the Feature label) Cleanup PR or issue introducing/requiring at least one clean-up operation

Comments

@johnsaigle
Copy link
Contributor

There is a filter in the form called Series UID but there is no corresponding column.

Entering data in the filter still causes columns to be hidden.

Not sure if this is a code issue or something to do with Raisinbread.

Testing on test-dev-loris.ca.
@johnsaigle johnsaigle added Bug PR or issue introducing/requiring bug fixes (not mutually exclusive with the Feature label) Cleanup PR or issue introducing/requiring at least one clean-up operation 22.0.0 TESTING labels Oct 30, 2019
@cmadjar
Copy link
Collaborator

cmadjar commented Oct 30, 2019

I just tried on testing with the following SeriesUID and it returned one row: 1.3.12.2.1107.5.2.32.35412.2013121311111335572611230.0.0.0

I guess you were just not entering correct data to try it out?

Not sure if the seriesUID should be shown in the data table. It might get messy to add it.

@johnsaigle
Copy link
Contributor Author

I found it later on a subpage of the module but it doesn't appear on the same page as the filter which is confusing.

@cmadjar cmadjar self-assigned this Nov 1, 2019
@johnsaigle johnsaigle mentioned this issue Nov 5, 2019
Merged
driusan pushed a commit that referenced this issue Nov 8, 2019
@johnsaigle @driusan
[MRI_Violations] Fixes permission bug; integration test to confirm bu…
1a25972 
…g fix; test plan update (#5546)

Allows users with the 'edit' permission to view the module even if they don't have 'view' permissions.

Adds an integration test to the above + code cleanup.

Rewrites the test plan to be up-to-date and easier to follow.

    Resolves #5419
    Resolves #5421
    Resolves #5422
@driusan
Copy link
Collaborator

driusan commented Nov 8, 2019

Fixed by above

@driusan driusan closed this as completed Nov 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cmadjar cmadjar

Labels
Bug PR or issue introducing/requiring bug fixes (not mutually exclusive with the Feature label) Cleanup PR or issue introducing/requiring at least one clean-up operation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@driusan @cmadjar @johnsaigle