Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MRI Violations] Request for help with imaging testing tasks #5422

Closed
johnsaigle opened this issue Oct 30, 2019 · 7 comments
Closed

[MRI Violations] Request for help with imaging testing tasks #5422

johnsaigle opened this issue Oct 30, 2019 · 7 comments
Assignees
@cmadjar
Labels
Meta PR does something that organizes, upgrades, or manages the functionality of the codebase Testing PR contains test plan or automated test code (or config files for Travis)

Comments

@johnsaigle
Copy link
Contributor

johnsaigle commented Oct 30, 2019 •
edited

  1. Verify one or two of the scans in the second table and ensure it indeed violates the MRI protocol. [Manual Testing]
  1. Upload scan that violates the mri_protocol table and ensure it shows up in the module as 'Could not identify scan type' [Manual Testing]
  1. Upload scan that violates the mri_protocol_checks table and ensure it shows up in the module as Protocol Violation [Manual Testing]

I am not familiar enough with imaging to test these points. Could someone help with this?
@johnsaigle johnsaigle added Testing PR contains test plan or automated test code (or config files for Travis) Meta PR does something that organizes, upgrades, or manages the functionality of the codebase 22.0.0 TESTING labels Oct 30, 2019
@cmadjar
Copy link
Collaborator

cmadjar commented Oct 30, 2019

@johnsaigle do you want to look at it with me tomorrow? This way you will know for next time :)

@johnsaigle
Copy link
Contributor Author

I'm not in tomorrow or Friday but we could do it next week?

@cmadjar
Copy link
Collaborator

cmadjar commented Oct 30, 2019

Sure! So far I have no other item on my calendar for Tuesday PM so your time will be mine if Tuesday PM works for you :).

@cmadjar
Copy link
Collaborator

cmadjar commented Nov 1, 2019

@xlecours we assigned you to fix the issues with MRI violations. We can talk on Monday if you have any questions regarding this module :). Thank you!

@cmadjar cmadjar assigned cmadjar and unassigned xlecours Nov 1, 2019
@cmadjar
Copy link
Collaborator

cmadjar commented Nov 1, 2019

@xlecours oups, this one is on me. I'll sit with @johnsaigle to go over the module. You are welcome to tag along. I'll assign you other MRI violation issues though.

@johnsaigle johnsaigle mentioned this issue Nov 5, 2019
Merged
@johnsaigle
Copy link
Contributor Author

johnsaigle commented Nov 5, 2019 •
edited

The conclusion of our meeting was that these items aren't appropriate for LORIS testing and instead indicate something to be tested within LORIS-MRI.

The test plan will be updated.

driusan pushed a commit that referenced this issue Nov 8, 2019
@johnsaigle @driusan
[MRI_Violations] Fixes permission bug; integration test to confirm bu…
1a25972 
…g fix; test plan update (#5546)

Allows users with the 'edit' permission to view the module even if they don't have 'view' permissions.

Adds an integration test to the above + code cleanup.

Rewrites the test plan to be up-to-date and easier to follow.

    Resolves #5419
    Resolves #5421
    Resolves #5422
@driusan
Copy link
Collaborator

driusan commented Nov 8, 2019

Fixed by above

@driusan driusan closed this as completed Nov 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cmadjar cmadjar

Labels
Meta PR does something that organizes, upgrades, or manages the functionality of the codebase Testing PR contains test plan or automated test code (or config files for Travis)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@driusan @cmadjar @johnsaigle @xlecours