Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[media] React warning on Upload tab #8702

Closed
jeffersoncasimir opened this issue May 11, 2023 · 1 comment · Fixed by #8721
Closed

[media] React warning on Upload tab #8702

jeffersoncasimir opened this issue May 11, 2023 · 1 comment · Fixed by #8721
Assignees
@skarya22
Labels
25.0.0 - Bugs Beginner Friendly PR or Issue appears to be easy for someone to use to familiarize themselves with LORIS

Comments

@jeffersoncasimir
Copy link
Contributor

jeffersoncasimir commented May 11, 2023 •
edited

Describe the bug
There is a React warning when selecting a PSCID in the dropdown of the Upload tab

To Reproduce

  1. ON TEST VM, Navigate to Media under Clinical in the menu with the media_write permission
  2. Go the Upload tab
  3. Select DCC145 from the PSCID dropdown
  4. See the following warning:

Warning: Use the `defaultValue` or `value` props on <select> instead of setting `selected` on <option>.
@jeffersoncasimir jeffersoncasimir mentioned this issue May 11, 2023
Closed
14 tasks
@racostas racostas added the Beginner Friendly PR or Issue appears to be easy for someone to use to familiarize themselves with LORIS label May 24, 2023
@skarya22 skarya22 mentioned this issue Jun 2, 2023
Merged
@skarya22 skarya22 added the Needs Work PR awaiting additional changes by the author or contains issues that the author needs to fix label Jun 5, 2023
@skarya22 skarya22 removed the Needs Work PR awaiting additional changes by the author or contains issues that the author needs to fix label Jun 12, 2023
driusan pushed a commit that referenced this issue Oct 17, 2023
@skarya22
[media] React Warning on Upload Tab (#8721)
91ceee1 
Modified Form.js to no longer use the "selected" attribute in option tags, and rather the "value" attribute of select tags.

Resolves #8702
@skarya22
Copy link
Contributor

skarya22 commented Jan 9, 2024

Closed by #8721

@skarya22 skarya22 closed this as completed Jan 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@skarya22 skarya22

Labels
25.0.0 - Bugs Beginner Friendly PR or Issue appears to be easy for someone to use to familiarize themselves with LORIS
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[media] React Warning on Upload Tab skarya22/Loris
3 participants
@jeffersoncasimir @racostas @skarya22