Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[media] React Warning on Upload Tab #8721

Merged
merged 5 commits into from Oct 17, 2023
Merged

[media] React Warning on Upload Tab #8721

merged 5 commits into from Oct 17, 2023

Conversation

skarya22
Copy link
Contributor

@skarya22 skarya22 commented Jun 2, 2023 •
edited

Brief summary of changes

  • Modified Form.js to no longer use the "selected" attribute in option tags, and rather the "value" attribute of select tags.

Testing instructions (if applicable)

If you cannot see the issue on your dev vm, you may need to delete ./node_modules and re-do npm install

  1. Open the media module and press upload then switch to a few different PSCIDs
  2. See if the warning appears in your console

Link(s) to related issue(s)

@skarya22 skarya22 changed the base branch from main to 25.0-release June 2, 2023 14:48
@skarya22 skarya22 changed the title 2023 06 02 react warning upload tab [media] React Warning on Upload Tab Jun 2, 2023
skarya22

This comment was marked as resolved.

Sign in to view

@skarya22 skarya22 removed the request for review from jeffersoncasimir June 6, 2023 15:17
@driusan
Copy link
Collaborator

driusan commented Jun 7, 2023

@skarya22 This seems to be failing the tests

@skarya22
Copy link
Contributor Author

@skarya22 This seems to be failing the tests

Tests are passing now and locally I am no longer getting the warning :)

@skarya22 skarya22 removed their assignment Aug 10, 2023
@laemtl laemtl self-requested a review August 10, 2023 15:31
@driusan driusan merged commit 91ceee1 into aces:25.0-release Oct 17, 2023
12 checks passed
@skarya22 skarya22 mentioned this pull request Jan 9, 2024
Closed
@ridz1208 ridz1208 added this to the 25.0.2 milestone Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@laemtl laemtl laemtl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
25.0.2
Development

Successfully merging this pull request may close these issues.

[media] React warning on Upload tab
4 participants
@skarya22 @driusan @laemtl @ridz1208