Ordering has been updated to be consistent as the file names #1477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gluneau
added
the
Feature
Current coverage is
|
| @@ -153,7 +153,7 @@ class NDB_Form_Imaging_Browser extends NDB_Form | |||
| WHERE SessionID=:SID AND (AcquisitionProtocolID IS NULL | |||
| OR AcquisitionProtocolID not in (1, 2, 3, 52)) | |||
| AND PendingStaging=0 $extra_where_string | |||
| ORDER BY files.OutputType, sel.Value DESC, AcquisitionProtocolID", | |||
There was a problem hiding this comment.
maybe ORDER BY files.OutputType, files.File would be better? The order would still be stable, but they'd be grouped by output type..
samirdas
added a commit
that referenced
this pull request
Jan 8, 2016
Ordering has been updated to be consistent as the file names
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MRI Browser: can volumes appear from left to right either in the order they were selected (or in alphabetical order). when the order changes, it makes it difficult to relate QC information from the 3rd image in the Volume Viewer back to the 002 image in the browser.