Ensure that UserID matches database when logging in #3178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
driusan
added
Bug
ridz1208
approved these changes
Oct 12, 2017
ridz1208
requested changes
Oct 12, 2017
The MySQL string comparison in SinglePointLogin was authenticating in a case-insensitive manner, resulting in various places in the code failing if they tried to compare $_SESSION['State']->getUsername() (which has the value from when the user logged in) with User::singleton()->getUsername() (which has the value from the database) in PHP (which, unlike MySQL, *is* case sensitive.) This updates the SinglePointLogin class so that it uses the username from the database, rather than the HTTP request for the username in $_SESSION['State'].
driusan
force-pushed
the
FixCaseInsensitiveUsername
branch
from
5e584e6
to
23dca3e
Compare
|
@ridz1208 Good catch, I updated it. |
ridz1208
approved these changes
Oct 12, 2017
ridz1208
added
the
Passed Manual Tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The MySQL string comparison in SinglePointLogin was
authenticating in a case-insensitive manner, resulting
in various places in the code failing if they tried to
compare $_SESSION['State']->getUsername() (which has
the value from when the user logged in) with User::singleton()->getUsername()
(which has the value from the database) in PHP (which,
unlike MySQL, is case sensitive.)
This updates the SinglePointLogin class so that it uses
the username from the database, rather than the HTTP request
for the username in $_SESSION['State'].