Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure that UserID matches database when logging in #3178

Merged
merged 1 commit into from Oct 17, 2017

Commits on Oct 12, 2017

  1. Ensure that UserID matches database when logging in

    The MySQL string comparison in SinglePointLogin was
    authenticating in a case-insensitive manner, resulting
    in various places in the code failing if they tried to
    compare $_SESSION['State']->getUsername() (which has
    the value from when the user logged in) with User::singleton()->getUsername()
    (which has the value from the database) in PHP (which,
    unlike MySQL, *is* case sensitive.)
    
    This updates the SinglePointLogin class so that it uses
    the username from the database, rather than the HTTP request
    for the username in $_SESSION['State'].
    driusan committed Oct 12, 2017
    Configuration menu
    Copy the full SHA
    23dca3e View commit details
    Browse the repository at this point in the history