Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Meta] Add CODE_OF_CONDUCT.md #5870

Merged
merged 3 commits into from Feb 4, 2020
Merged

Conversation

driusan
Copy link
Collaborator

@driusan driusan commented Dec 17, 2019

This adds a CODE_OF_CONDUCT.md file with the goal of being as
non-politicized as possible. It defers to MCIN and McGill University
codes and policies with a vague paragraph trying to include external
contributors, who might otherwise think that we don't accept external
contributions.

Testing instructions (if applicable)

  1. Hire a lawyer and/or contact your local HR rep to ask if this code implies any legal or ethical issues that we should be aware of.

Resolves #5864

This adds a CODE_OF_CONDUCT.md file with the goal of being as
non-politicized as possible. It defers to MCIN and McGill University
codes and policies (which presumably have been vetted by HR and legal
departments applicable to us) with a vague paragraph imploring respect
and good faith for people who are not part of those organizations.
@driusan driusan added the Meta PR does something that organizes, upgrades, or manages the functionality of the codebase label Dec 17, 2019
@johnsaigle
Copy link
Contributor

Instances of abusive, harassing, or otherwise unacceptable behavior may be reported by contacting the project team at cbrain-support.mni@mcgill.ca.

I liked this line from the CBRAIN repo. It would be nice for contributors to have some communication channel in case of a problem.

@driusan
Copy link
Collaborator Author

driusan commented Dec 17, 2019

The problems I have with that line are:

  1. The language is punitive, not positive.
  2. If we created an email address it implies that there are some resources monitoring it and taking action with complaints. Having an email address that either goes into the void or without appropriate safeguards about how things sent to it are handled (privacy, legal reporting obligations, etc) is worse than having no address. We do not have any trained mediators to handle conflicts with external collaborators and the McGill or MCIN policies referred to should already have their own enforcement mechanisms with appropriate safeguards and resources in place (or at least I'd hope.)
  3. All the communication mediums involving LORIS that I can think of (GitHub, slack, loris-dev) are already fairly well monitored.

@johnsaigle
Copy link
Contributor

Yeah I guess you're right we don't have resources for that sort of thing. We can punt it to the HR department because we have one.

@johnsaigle
Copy link
Contributor

Should we add this to the ReadTheDocs nav bar?

Copy link
Member

@maltheism maltheism left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the simplicity of the conduct.

Copy link
Contributor

@christinerogers christinerogers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@driusan did you base this on any template, in whole or in part?
Asking because this reads not as a code of conduct, rather as a disclaimer/caveat to say participate at your own risk

I can see other tweaks we cold make too so it sounds like we actually welcome contributions instead of just expressing wariness of liability.
e.g. I'd like to see the However, removed, which sets a negative tone for what follows.

I liked this line from the CBRAIN repo. It would be nice for contributors to have some communication channel in case of a problem.
@johnsaigle W do have at least 1-2 well-monitored and private Loris emails that can be used for reporting, I think it would be a gesture of good faith to put such an address/channel here. I understand the points against but again I think it would help a lot with the done of this.

@driusan
Copy link
Collaborator Author

driusan commented Dec 23, 2019

@christinerogers This was explicitly not based on any template because I believe decisions such as "adopt [template] as a code of conduct" should be made at an organizational level, not a repository/team level.

My goal with this document is to explicitly reference the code already exists (follow the organizational code of conduct and any other codes that apply to you) without claiming authority to make decisions about a parallel grievance process.

Copy link
Contributor

@PapillonMcGill PapillonMcGill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simple and respectful. I like it.

Creating a complex code of conduct might attract people who want to find cracks in the code of conduct and abuse them.

@christinerogers
Copy link
Contributor

Points above noted and appreciated, @driusan and @PapillonMcGill
I still think that adding the Code of Conduct as CBRAIN has done - https://github.com/aces/cbrain/blob/master/.github/CODE_OF_CONDUCT.md
will provide many more benefits than real liabilities.
We already adhere to its practices and values pretty naturally and collaboratively as a team and community, and I think we would see better results in the bigger external picture in following this standard boilerplate as CBRAIN does since that is already our intentional practice.

@PapillonMcGill
Copy link
Contributor

PapillonMcGill commented Jan 6, 2020

Yes indeed, the cbrain code of conduct is quite extensive and also in a positive tone (for most of it).
We could include an existing (or new) email address. It would need (IMHO) at least to be viewed by a few persons, not the entire team (privacy).
In the mean time, I am sure that someone wanting to make a complain could find some email address within a few minutes of search.
I think the decision to include or not such an email address should be taken not by one person but the maintainer team (and leadership). This would go in line with Project maintainers who do not follow or enforce the Code of Conduct in good faith may face temporary or permanent repercussions as determined by other members of the project's leadership. as written on cbrain code of conduct.

@christinerogers
Copy link
Contributor

@PapillonMcGill per my previous comment, there is already an existing email we can use, that's no problem. (I won't publish here though until decided)

the [McGill Centre For Integrative Neuroscience](http://mcin.ca/). Contributors
should comply with all relevant policies and codes of their respective organizations.

As open source software we encourage contributions from other sources. When interacting
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
As open source software we encourage contributions from other sources. When interacting
When interacting

I don't think this part is necessary.

@johnsaigle
Copy link
Contributor

Is it worth having a broad conversation about this in a LORIS meeting?

My preference is something more like what CBRAIN has but as Dave as said, this is more of an organizational decision rather than a coder/repo decision. Maybe this is ultimately in @samirdas's court.

@driusan
Copy link
Collaborator Author

driusan commented Feb 4, 2020

@samirdas sent me some text that he asked to be used for the code of conduct. This needs to be merged to have a stable URL to add to grants, any questions or suggested modifications should go through him rather this PR review.

@driusan driusan merged commit 694d8dc into aces:master Feb 4, 2020
@johnsaigle johnsaigle mentioned this pull request Feb 10, 2020
@ridz1208 ridz1208 added this to the 23.0.0 milestone Feb 25, 2020
@christinerogers christinerogers added Add to Release Notes PR change should be highlighted in Release notes (important security, features and bugfixes) Document at Release PR adds or changes a feature such that the wiki (or other documentation) must be updated Needs Changelog Update Update the CHANGELOG file to reflect changes in this PR labels May 19, 2020
@christinerogers
Copy link
Contributor

christinerogers commented May 19, 2020

Adding tags so that this is noted in the 23 Release notes / changelog

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Add to Release Notes PR change should be highlighted in Release notes (important security, features and bugfixes) Document at Release PR adds or changes a feature such that the wiki (or other documentation) must be updated Meta PR does something that organizes, upgrades, or manages the functionality of the codebase Needs Changelog Update Update the CHANGELOG file to reflect changes in this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create Code of Conduct document
6 participants