[Core] Remove duplicated getActiveModules function #7446
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kongtiaowang @ridz1208 can one of you review/test this? This is blocking the DQT API because, in removing the function, it also updates all the places that needed it to have access to a |
driusan
force-pushed
the
RemoveDuplicateFunction
branch
2 times, most recently
from
3aad732
to
4dd86a9
Compare
There was a static getActiveModules function in the module class as well as a getActiveModules function in the LorisInstance class. This removes the duplicate and unnecessary function, cleaning up the references to the non-static version now that NDB_Page has a LorisInstance object passed in the constructor.
driusan
force-pushed
the
RemoveDuplicateFunction
branch
from
01a5a7e
to
7fff15b
Compare
ridz1208
reviewed
Oct 25, 2022
| @@ -79,7 +79,6 @@ class Dashboard extends \NDB_Form | |||
| // calculating the body. | |||
| $factory = \NDB_Factory::singleton(); | |||
| $user = $factory->user(); | |||
|
|
|||
There was a problem hiding this comment.
I think we should discuss this change
ridz1208
approved these changes
Oct 25, 2022
regisoc
added a commit
to regisoc/Loris
that referenced
this pull request
Oct 27, 2022
Following aces#7446, one of the changes involves `php/libraries/NullModule.class.inc` that now requires a `LorisInstance` type parameter. This fix adds this parameter in the lorisform_parser.php script.
driusan
pushed a commit
that referenced
this pull request
Nov 1, 2022
Following #7446, one of the changes involves php/libraries/NullModule.class.inc that now requires a LorisInstance type parameter. This fix adds a missing parameter in the lorisform_parser.php script.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a static getActiveModules function in the module class
as well as a getActiveModules function in the LorisInstance class.
This removes the duplicate and unnecessary function, cleaning up the
references to the non-static version now that NDB_Page has a LorisInstance
object passed in the constructor and all references should be able to use
the non-static version.