Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for tools/lorisform_parser #8201

Merged
merged 2 commits into from Nov 1, 2022
Merged

Conversation

regisoc
Copy link
Contributor

@regisoc regisoc commented Oct 27, 2022

Following #7446, one of the changes involves php/libraries/NullModule.class.inc that now requires a LorisInstance type parameter.

This fix adds a missing parameter in the lorisform_parser.php script.

Following aces#7446, one of the changes involves
`php/libraries/NullModule.class.inc` that now requires a
`LorisInstance` type parameter.

This fix adds this parameter in the lorisform_parser.php script.
@regisoc regisoc requested a review from driusan October 27, 2022 15:00
Copy link
Collaborator

@driusan driusan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will merge after the tests pass

@driusan driusan merged commit 9c2ae64 into aces:main Nov 1, 2022
@ridz1208 ridz1208 added this to the 25.0.0 milestone Mar 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants