[instruments/instrument_manager] Migrate instrument permissions from config.xml to database #8302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
driusan
added
Add to Release Notes
driusan
force-pushed
the
InstrumentPermisssionsDatabase
branch
from
ef7ac69
to
96a1d1a
Compare
|
Blocked by #8290 |
driusan
added
the
Blocked
ridz1208
added
the
Needs Rebase
ridz1208
reviewed
Feb 21, 2023
Makefile
Outdated
Comment on lines
58
to
59
| instrument_manager: | ||
| target=instrument_manager npm run compile |
There was a problem hiding this comment.
is this a leftover or are we adding this for every module now?
There was a problem hiding this comment.
I've been adding it for modules when I work on them because it makes life easier but haven't systematically added every module.
ridz1208
reviewed
Feb 21, 2023
driusan
force-pushed
the
InstrumentPermisssionsDatabase
branch
from
ab717a8
to
b28ce82
Compare
driusan
removed
Needs Rebase
|
Note: this will need to be rebased/re-tested after #8422 in case of conflicts with the instrument manager |
ridz1208
approved these changes
Mar 15, 2023
TODO: - Create table and patch - Write script to migrate - Create frontend for managing table
driusan
force-pushed
the
InstrumentPermisssionsDatabase
branch
from
88b56c1
to
28bf6cf
Compare
driusan
added
the
Caveat for Existing Projects
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This migrates instrument permissions from the config.xml to the database in a new
testnames_permissions_reltable. The table can be managed from the frontend in theinstrument_managermodule by any user who has theinstrument_manager_writepermission. The scripttools/single_use/migrate_instrument_permissions.phpcan be used by existing projects to migrate their permissions from the config.xml to the new table.