Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Genomic Browser] UserSiteMatch fix #8468

Merged
merged 1 commit into from Mar 22, 2023
Merged

[Genomic Browser] UserSiteMatch fix #8468

merged 1 commit into from Mar 22, 2023

Conversation

laemtl
Copy link
Contributor

@laemtl laemtl commented Mar 20, 2023

Fix a Fatal error on the Genomic Browser tabs: [ERROR] Can not implement UserSiteMatch on a resource type that has no sites.

To test:
Use a user that have permission Genomic Browser: View Genomic Data - Own Sites but do not have genomic_browser_view_allsites. Visit the Genomic Browser and check that the tabs loads without error.

Fixes #7589

@laemtl laemtl added 24.0.0-bugs Issues or bug fix PRs that were raised during the testing of release 24.0.0 Blocking PR should be prioritized because it is blocking the progress of another task and removed Blocking PR should be prioritized because it is blocking the progress of another task labels Mar 20, 2023
@laemtl laemtl changed the base branch from main to 24.1-release March 20, 2023 20:33
@laemtl laemtl force-pushed the genomic-browser-UserSiteMatch-fix branch from ade3695 to 270d933 Compare March 20, 2023 20:36
@laemtl laemtl requested a review from racostas March 20, 2023 20:36
racostas
racostas approved these changes Mar 22, 2023
View reviewed changes
Copy link
Contributor

@racostas racostas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@racostas racostas added the Passed Manual Tests PR has undergone proper testing by at least one peer label Mar 22, 2023
@driusan driusan merged commit ae2975e into aces:24.1-release Mar 22, 2023
9 checks passed
@ridz1208 ridz1208 added this to the 24.1.3 milestone Mar 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@racostas racostas racostas approved these changes

Assignees

@racostas racostas

Labels
24.0.0-bugs Issues or bug fix PRs that were raised during the testing of release 24.0.0 Passed Manual Tests PR has undergone proper testing by at least one peer
Projects
None yet
Milestone
24.1.3
4 participants
@laemtl @racostas @driusan @ridz1208