Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update node 18 #32

Closed
wants to merge 2 commits into from
Closed

Update node 18 #32

wants to merge 2 commits into from

Conversation

erg
Copy link

@erg erg commented Apr 20, 2022

Node 18 is out. vue create depends on this library somehow and chokes on node 18.

error @achrinza/node-ipc@9.2.2: The engine "node" is incompatible with this module. Expected version "8 || 10 || 12 || 14 || 16 || 17". Got "18.0.0"
error Found incompatible module.

I ran npm test with node 18 and the tests seem to pass. You might have to release a patch release after this.

node --version
v18.0.0

@achrinza
Copy link
Owner

Thanks for the PR, @erg. Some additional changes are required (e.g. CI matrix, DCO sign-off, correct base branch) of which I've applied in a separate set of PRs.

Closed in favour of #34 and #35

@erg erg closed this Apr 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants