fix cell id bug in fastRasterize
#12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I've fixed the namespacing issues, since you didn't properly import the functions you used; however, there are still test failures. @YongLuo007 please ensure it passes `R CMD check` locally. You can keep adding to this PR instead of opening a new one.
…development Conflicts: R/faster-rasters.R
@YongLuo007 just a reminder that you do not need to open mulitple PRs for the same thing. Simply add commits to your existing PR.
achubaty
pushed a commit
that referenced
this pull request
Apr 10, 2017
* improved tests for `fastRasterize` * add @YongLuo007 as contributor
achubaty
changed the title
fastRasterize
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alex, please check the revised files. Thanks.