Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add caching for API calls #21

Closed
acifani opened this issue Apr 22, 2018 · 1 comment
Closed

Add caching for API calls #21

acifani opened this issue Apr 22, 2018 · 1 comment
Labels
enhancement

Comments

@acifani
Copy link
Owner

acifani commented Apr 22, 2018

Add a local caching layer that will store API responses. Ideally we would want different maximum age for each type of call (competition, team, fixutres, etc).

Benefits:

  • Faster
  • Make more requests per day, without asking for an API key

Possible issues:

  • Stale data
@acifani
Copy link
Owner Author

acifani commented May 6, 2018

Merged in fc18217

@acifani acifani closed this as completed May 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@acifani