fix: check for NoMethodError
instead of NotImplementedError
#545
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pundit have recently changed to using
NoMethodError
, which breaks our spec - the main benefit of this change is that the new error extends fromStandardError
so in theory is easier to catch; however, it seems the community is divided as aside from the different superclass the existing error is more accurate sinceNoMethodError
is meant to be thrown when the class does notrespond_to?
the method in question and that is not true.I personally would like to keep using
NotImplementedError
though I'm happy to change if someone does prove a real-world situation where it's more burdson to catch (or that our error monitoring won't catch it), but I feel that should be a separate conversation - so this PR is changing it back to maintain our current status quo until such time that we do decide to change.