Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: check for NoMethodError instead of NotImplementedError #545

Merged
merged 1 commit into from
May 31, 2024
Merged

fix: check for NoMethodError instead of NotImplementedError #545

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions variants/pundit/template.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,12 @@
run "rails g pundit:install"
run "rails g pundit:policy example"

# Pundit uses NoMethodError which is easier to catch as it extends from StandardError,
# but it's technically not correct as our class does respond to the method in question
#
# For now, we're just going to stick with the more traditional error for this situation
gsub_file! "app/policies/application_policy.rb", "raise NoMethodError", "raise NotImplementedError"

copy_file "spec/policies/example_policy_spec.rb", force: true
copy_file "spec/policies/application_policy_spec.rb", force: true

Expand Down
Loading