fix: support shakapacker v8
#546
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
G-Rath
force-pushed
the
upgrade-shakapacker-v8
branch
from
2af8c6a
to
d5c5e91
Compare
G-Rath
requested review from
eoinkelly,
lukeify,
halles,
joshmcarthur,
robotdana,
JacobBriggsAckama,
brooke-m and
hopkincame
This comment was marked as outdated.
This comment was marked as outdated.
G-Rath
force-pushed
the
upgrade-shakapacker-v8
branch
from
d5c5e91
to
7cc31ce
Compare
joshmcarthur
approved these changes
Jun 30, 2024
lukeify
approved these changes
Jul 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The most notable feature change in v8 is that Shakapacker is now JS package manager agnostic by default, using the
packageManagerproperty to determine which package manager to use (otherwise defaulting tonpm, like Node itself).A side-effect of this means that
shakapacker:installnow merges with existingpackage.jsons rather than always overwriting it (that way you can setpackageManagerbefore running the installer); this means we could potentially refactor some of ourpackage.jsonrelated code to reduce duplication but it'll still all work as-is so I've left that for a potential follow-up PR.There are other breaking changes which are detailed in the upgrade guide but they're mainly around fixing existing behaviour and removing deprecated stuff like the
webpackernamespace; they will be relevant for our existing applications but don't impact new applications.