Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix indentation for marshalling sgml #3

Merged
merged 1 commit into from
Jul 1, 2019
Merged

Fix indentation for marshalling sgml #3

merged 1 commit into from
Jul 1, 2019

Conversation

JohnStarich
Copy link
Contributor

I left a bug in the indentation implementation 😬
This PR fixes the indentation so instead of no dedent, we get the correct double dedent after a non-closing sgml element.

before:

<thing>
    <a>
        <b>some B</a>
    </thing>

after:

<thing>
    <a>
        <b>some B
    </a>
</thing>

@aclindsa aclindsa merged commit 453d2c6 into aclindsa:master Jul 1, 2019
@JohnStarich JohnStarich deleted the bugfix/fix-sgml-indent branch July 2, 2019 01:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aclindsa aclindsa aclindsa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JohnStarich @aclindsa