Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace submit subcommand with sync #41

Merged
merged 21 commits into from
Oct 16, 2023
Merged

Replace submit subcommand with sync #41

merged 21 commits into from
Oct 16, 2023

Conversation

EthanThatOneKid
Copy link
Contributor

Resolves #34.

@EthanThatOneKid
passing test "DenoKvLeaderboardClient" step "sync"
53a90d6 
WIP. TODO: resolve failing tests
```
DenoKvLeaderboardClient ... getLatestSeason => ./lib/leaderboard/denokv/denokv_leaderboard_client_test.ts:67:11
DenoKvLeaderboardClient ... listSeasons => ./lib/leaderboard/denokv/denokv_leaderboard_client_test.ts:73:11
DenoKvLeaderboardClient ... getSeason => ./lib/leaderboard/denokv/denokv_leaderboard_client_test.ts:79:11
```
@EthanThatOneKid
fix test steps
58bff1e 
Fix test steps `getLatestSeason`, `listSeasons , and `getSeason`.
@EthanThatOneKid EthanThatOneKid marked this pull request as ready for review October 12, 2023 04:48
@EthanThatOneKid EthanThatOneKid mentioned this pull request Oct 13, 2023
Closed
EthanThatOneKid
EthanThatOneKid commented Oct 15, 2023
View reviewed changes
api/types.ts Show resolved Hide resolved
lib/leaderboard/denokv/denokv_leaderboard_client.ts Outdated Show resolved Hide resolved
EthanThatOneKid
EthanThatOneKid commented Oct 15, 2023
View reviewed changes
api/dailies.ts Outdated Show resolved Hide resolved
@EthanThatOneKid EthanThatOneKid mentioned this pull request Oct 16, 2023
Closed
@EthanThatOneKid EthanThatOneKid linked an issue Oct 16, 2023 that may be closed by this pull request
Add synced_at property to api.Season #44
Closed
EthanThatOneKid added a commit that referenced this pull request Oct 16, 2023
@EthanThatOneKid
Squashed commit of the following:
d2a5511 
commit 0ac9cbe
Author: Ethan Davidson <31261035+EthanThatOneKid@users.noreply.github.com>
Date:   Sun Oct 15 20:23:40 2023 -0700

    Update HANDBOOK.md

    Resolves <#41 (comment)>.

commit 1ae4439
Author: Ethan Davidson <31261035+EthanThatOneKid@users.noreply.github.com>
Date:   Sun Oct 15 20:08:04 2023 -0700

    Update instructions sent in daily webhook embed

    Resolves <#41 (comment)>.

commit 2abcf63
Author: Ethan Davidson <31261035+EthanThatOneKid@users.noreply.github.com>
Date:   Sun Oct 15 19:58:38 2023 -0700

    sync: Overwrite to empty season for new seasons

    Resolves <#41 (comment)>.

commit 1b1890f
Author: Ethan Davidson <31261035+EthanThatOneKid@users.noreply.github.com>
Date:   Sun Oct 15 19:31:40 2023 -0700

    Add `synced_at` property to `api.Season`

    Resolves #44, <#41 (comment)>.

commit bf70308
Author: Ethan Davidson <31261035+EthanThatOneKid@users.noreply.github.com>
Date:   Sun Oct 15 19:14:55 2023 -0700

    Change `sync` subcommand response to embeds

    Resolves <#41 (comment)>.
EthanThatOneKid added a commit that referenced this pull request Oct 16, 2023
@EthanThatOneKid
Squashed commit of the following:
b02b40d 
commit 10bf85a
Author: Ethan Davidson <31261035+EthanThatOneKid@users.noreply.github.com>
Date:   Sun Oct 15 22:29:46 2023 -0700

    `updateLatestSeason`: forceful kv set op

commit 9896822
Author: Ethan Davidson <31261035+EthanThatOneKid@users.noreply.github.com>
Date:   Sun Oct 15 21:53:46 2023 -0700

    refactor `executeDailyWebhook` logic

commit 0ac9cbe
Author: Ethan Davidson <31261035+EthanThatOneKid@users.noreply.github.com>
Date:   Sun Oct 15 20:23:40 2023 -0700

    Update HANDBOOK.md

    Resolves <#41 (comment)>.

commit 1ae4439
Author: Ethan Davidson <31261035+EthanThatOneKid@users.noreply.github.com>
Date:   Sun Oct 15 20:08:04 2023 -0700

    Update instructions sent in daily webhook embed

    Resolves <#41 (comment)>.

commit 2abcf63
Author: Ethan Davidson <31261035+EthanThatOneKid@users.noreply.github.com>
Date:   Sun Oct 15 19:58:38 2023 -0700

    sync: Overwrite to empty season for new seasons

    Resolves <#41 (comment)>.

commit 1b1890f
Author: Ethan Davidson <31261035+EthanThatOneKid@users.noreply.github.com>
Date:   Sun Oct 15 19:31:40 2023 -0700

    Add `synced_at` property to `api.Season`

    Resolves #44, <#41 (comment)>.

commit bf70308
Author: Ethan Davidson <31261035+EthanThatOneKid@users.noreply.github.com>
Date:   Sun Oct 15 19:14:55 2023 -0700

    Change `sync` subcommand response to embeds

    Resolves <#41 (comment)>.
@EthanThatOneKid
Copy link
Contributor Author

EthanThatOneKid commented Oct 16, 2023 •
edited
Loading

QA Testing and Development of LC-Dailies Bot (October 14th-15th, 2023)

Background:
The events described in this historical account occurred on October 14th and 15th, 2023 taking place on Discord. The time zone for the activities mentioned is Pacific Standard Time (PST).

October 14th:

  • 2:00 PM: Ethan (he/Webmaster) initiates a task to complete the "secrets doc," a confidential document hosted on Google Docs.

  • 3:25 PM: Ethan (he/Webmaster) begins a series of actions related to the QA database, including an attempt to register in the QA database. This registration is successful under the Leetcode username "LC-Dailies."

  • 3:34 PM: Ethan successfully submits a Leetcode solution for the current season.

  • 3:36 PM: Ethan comments on the process of setting up a QA environment, describing it as not too complex but potentially tedious for multiple environments.

  • 3:50 PM: Ethan mentions testing the QA sync subcommand, suggesting ongoing efforts to ensure the bot's functionality.

  • 6:40 PM: Casual greetings are exchanged between participants, including "sǝʌ⅄sʍollɐH" and "evan j."

October 15th:

  • 12:11 PM: Ethan skips a manual test related to syncing without any new submissions.

  • 12:12 PM: Ethan initiates Manual Test 2, involving syncing with an empty season and one new submission. The bot confirms synchronization of "Season 01HC69AT007FQ3YW2RMKD6B5JM."

  • 3:07 PM: Justin inquires about the ongoing activity.

  • 4:15 PM: Ethan explains that the testing is related to a bot used in the "algo-chat" channel and expresses concerns about bot notifications affecting everyone.

  • 4:16 PM: Karni suggests that Justin might not have muted the channel, leading to his curiosity.

  • 4:19 PM: Ethan elaborates on the bot's purpose, describing it as a system that splits daily Leetcode challenges by week and calculates weekly scores for registered players. He mentions that it is hosted on Deno Deploy.

  • 8:35 PM: The bot reports a successful synchronization of "Season 01HCRA3V00MS135M8MZ9BJG5QC," with a user named Ethanthatonekid receiving 90 points.

  • 8:39 PM: Ethan concludes Manual Test 2 with a positive outcome, stating that the sync subcommand is working as intended, and the new submission appears in the latest season object.

  • 9:56 PM: Ethan solves the daily Leetcode question, provides a link to the solution, and announces plans to execute a POST request.

  • 10:38 PM: Ethan encounters an error but fixes it, attributing the problem to sending the fetch request in the wrong browser tab.

  • 10:48 PM: Ethan explains that the new daily Leetcode question embed allows automatic synchronization of the season with Leetcode, signaling that the latest season has been synced.

  • 10:51 PM: Ethan confirms that his earlier submission had automatically synced to the database without requiring a manual command.

  • 10:52 PM: Ethan notes the matching submission ID with ⁠lc-dailies-qa⁠ and an accurate synced_at timestamp with ⁠lc-dailies-qa⁠.

  • 10:58 PM: Ethan notes the success of Manual Test 3, highlighting the readiness of a specific URL or repository (https://oss.acmcsuf.com/lc-dailies/pull/41) associated with the project. This test demonstrates the effectiveness of the bot's daily synchronization process.

karnikaavelumani
karnikaavelumani approved these changes Oct 16, 2023
View reviewed changes
Copy link
Contributor

@karnikaavelumani karnikaavelumani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! ʕ•̫͡•ʕ•̫͡•ʔ•̫͡•ʔ•̫͡•ʕ•̫͡•ʔ•̫͡•ʕ•̫͡•ʕ•̫͡•ʔ•̫͡•ʔ

@EthanThatOneKid EthanThatOneKid merged commit 3ac6b70 into main Oct 16, 2023
5 checks passed
@EthanThatOneKid EthanThatOneKid deleted the fix/34 branch October 16, 2023 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karnikaavelumani karnikaavelumani karnikaavelumani approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add synced_at property to api.Season Drop submit subcommand
2 participants
@EthanThatOneKid @karnikaavelumani