Add ArtFiles.de DNS API plugin #3959
Conversation
|
@Neilpang Please approve my first contribution so that Actions run. |
|
Pinging @Neilpang as a kind reminder since I'm eagerly waiting to see this plugin merged into ACME… 😍 |
|
fix the CI Checks first: |
|
How to re-issue the checks without another commit? Because back in the days, some checks where broken under certain circumstances, i. e. nowadays might succeed without any change… |
Job(s) re-run, no error message given - just the Docker step idling & GitHub canceling it after 6 hours of doing nothing.
I did read those docs. I've read it about 23 times actually! Those docs are pretty good for setup, but totally useless regarding any occurring error or - as in my case - zero error & zero information for why Docker idled ~6 hours & GitHub then terminating it. So, for code's sake, either tell me how to find the error, enable the debug logs to actually show something useful or just merge this PR as I run it every ~60 days on my own systems successfully without any errors, hence - in theory at least - already passing those darn tests. |
|
@Neilpang Fixed all bugs & the tests succeeded - due to API write limits of my provider (not more than 50 API write calls per day for each domain), I could only execute the full DNS test suite over the course of several days (and the latest run, triggered by my RI merge, failed for that very same reason)… Still, the tests succeeded, so I'm looking forward to your merge of my DNS API addition to ACME.sh. |
|
It seems you didn't read the guide carefully:
|
|
@Neilpang Created issue #4718 & also added the URL to the DNS API plugin file as requested. Though, now |
|
did you add the usage? |
|
can you please check this guide one by one? |
Are you serious? You'd just have to search |
Can you please accept the fact that my script is ready for merge as well as immediate usage?
|
|
it seems the DNS test never passed: Can you fix it? |
There's nothing to fix on my end, but on yours - just as I told you earlier, mentioning a bug in Even longer ago, I mentioned that all bugs were fixed & the script runs just fine, even on my production system, but that sometimes the Docker script times out for no reason (at least none caused by me or my script). So, until mentioned bug in |
|
the egrep issue was fixed, rebase your code. |
|
please make sure the DNS tests passing before I can merge the code. |
Did so yesterday, no commits to update to - did it again right now, updated 11 commits.
Done, see passed checks below. |
|
@Neilpang Even tried to run all the DNS tests again (marked as [Mon Jul 31 14:***4:34 UTC 2***23] DNS API error: {"error":"daily limit for this domain exceeded","status":"ERROR"}That limit is 50 API write-calls within 24 hours & since each test requires at least 4 writes (1 for writing the TXT challenge value, 1 for deleting it, yet another 1 for writing the wildcard TXT challenge value & finally another 1 for deleting it), I can only test up to 12 systems. That's why each system up to & including Even worse, the write-call limit is per "rolling 24 hours", i. e. I can't start at ~23:45 to execute 50 calls & get another 50 free calls at 00:00 - instead, the 24-hours-timer starts whenever the first write-call is executed. The only way to work around would be splitting the |
Usage instructions already added to DNS API guide.