This repository has been archived by the owner on Mar 16, 2024. It is now read-only.
Stop rerunning create jobs on non-generation bumping updates #2307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thedadams
requested review from
njhale,
iwilltry42,
g-linville and
tylerslaton
tylerslaton
approved these changes
Oct 31, 2023
If an app is updated in such a way that the generation is not bumped (e.g. an annotation or label is add/removed/modified), then any job that is create-only would rerun if the generation of the app is 1. This change ensures that create-only jobs will not be rerun in this instance. Signed-off-by: Donnie Adams <donnie@acorn.io>
thedadams
force-pushed
the
no-create-rerun
branch
from
c944bc6
to
c2ece19
Compare
iwilltry42
approved these changes
Nov 1, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If an app is updated in such a way that the generation is not bumped (e.g. an annotation or label is add/removed/modified), then any job that is create-only would rerun if the generation of the app is 1. This change ensures that create-only jobs will not be rerun in this instance.
Checklist
This is a title (#1216). Here's an example