Skip to content
This repository has been archived by the owner on Mar 16, 2024. It is now read-only.

Stop trying to parse empty image names #2325

Merged
merged 1 commit into from
Nov 13, 2023
Merged

Stop trying to parse empty image names #2325

merged 1 commit into from
Nov 13, 2023

Conversation

thedadams
Copy link
Contributor

When determining image permissions for apps with auto-upgrade pattern, the handler would mistakenly try to parse a blank image name. This change will ignore empty image names.

Checklist

  • The title of this PR would make a good line in Acorn's Release Note's Changelog
  • The title of this PR ends with a link to the main issue being address in parentheses, like: This is a title (#1216). Here's an example
  • All relevant issues are referenced in the PR description. NOTE: don't use GitHub keywords that auto-close issues
  • Commits follow contributing guidance
  • Automated tests added to cover the changes. If tests couldn't be added, an explanation is provided in the Verification and Testing section
  • Changes to user-facing functionality, API, CLI, and upgrade impacts are clearly called out in PR description
  • PR has at least two approvals before merging (or a reasonable exception, like it's just a docs change)

Issue: https://github.com/acorn-io/manager/issues/1556

@thedadams
Stop trying to parse empty image names
21b2601 
When determining image permissions for apps with auto-upgrade pattern,
the handler would mistakenly try to parse a blank image name. This
change will ignore empty image names.

Signed-off-by: Donnie Adams <donnie@acorn.io>
@thedadams thedadams merged commit f4d08b8 into acorn-io:main Nov 13, 2023
4 checks passed
@thedadams thedadams deleted the gh-1556 branch November 13, 2023 19:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tylerslaton tylerslaton tylerslaton approved these changes

@njhale njhale njhale approved these changes

@StrongMonkey StrongMonkey StrongMonkey approved these changes

@g-linville g-linville g-linville approved these changes

@sosodev sosodev Awaiting requested review from sosodev

@iwilltry42 iwilltry42 Awaiting requested review from iwilltry42

@keyallis keyallis Awaiting requested review from keyallis

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@thedadams @njhale @StrongMonkey @g-linville @tylerslaton