Skip to content
This repository has been archived by the owner on Mar 16, 2024. It is now read-only.

Fix memory values in resolved offerings (#2389) #2390

Merged
merged 1 commit into from
Dec 22, 2023

Conversation

g-linville
Copy link
Contributor

for #2389

My initial implementation of resolved offerings did not account for cases where the user overrode the memory request for all container in the app using the --memory argument with acorn run. This fixes that.

Checklist

  • The title of this PR would make a good line in Acorn's Release Note's Changelog
  • The title of this PR ends with a link to the main issue being address in parentheses, like: This is a title (#1216). Here's an example
  • All relevant issues are referenced in the PR description. NOTE: don't use GitHub keywords that auto-close issues
  • Commits follow contributing guidance
  • Automated tests added to cover the changes. If tests couldn't be added, an explanation is provided in the Verification and Testing section
  • Changes to user-facing functionality, API, CLI, and upgrade impacts are clearly called out in PR description
  • PR has at least two approvals before merging (or a reasonable exception, like it's just a docs change)

Signed-off-by: Grant Linville <grant@acorn.io>
@g-linville g-linville merged commit 924581d into acorn-io:main Dec 22, 2023
4 checks passed
@g-linville g-linville deleted the fix-resolved-offerings-memory branch December 22, 2023 02:37
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants