Skip to content
This repository has been archived by the owner on Mar 16, 2024. It is now read-only.

fix: cli: return an error when creating a secret that already exists (#2408) #2417

Merged

Conversation

g-linville
Copy link
Contributor

for #2408

Pretty simple little fix.

Checklist

  • The title of this PR would make a good line in Acorn's Release Note's Changelog
  • The title of this PR ends with a link to the main issue being address in parentheses, like: This is a title (#1216). Here's an example
  • All relevant issues are referenced in the PR description. NOTE: don't use GitHub keywords that auto-close issues
  • Commits follow contributing guidance
  • Automated tests added to cover the changes. If tests couldn't be added, an explanation is provided in the Verification and Testing section
  • Changes to user-facing functionality, API, CLI, and upgrade impacts are clearly called out in PR description
  • PR has at least two approvals before merging (or a reasonable exception, like it's just a docs change)

Signed-off-by: Grant Linville <grant@acorn.io>
@g-linville
Copy link
Contributor Author

The integration test that is failing here also fails on main, so I'm just going to merge this.

@g-linville g-linville merged commit 4eb9cea into acorn-io:main Jan 17, 2024
3 of 4 checks passed
@g-linville g-linville deleted the secret-creation-duplicate-name-fix branch January 17, 2024 01:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants