This repository has been archived by the owner on Mar 16, 2024. It is now read-only.
[fix] - promptOrder now works for credentials (#2386) #2453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cloudnautique
changed the title
g-linville
approved these changes
Jan 23, 2024
thedadams
approved these changes
Jan 23, 2024
pkg/login/login.go
Outdated
| if len(value) == 0 { | ||
| value = []byte(def) | ||
| paramsData := app.Status.AppSpec.Secrets[secretName].Params.GetData() | ||
| if paramsData != nil { |
There was a problem hiding this comment.
nit: nil check here isn't necessary.
Signed-off-by: Bill Maxwell <cloudnautique@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original implementation always ended up with an empty []string{} resulting in never following promptOrder.
Based on my understanding it wouldn't get typed from ([]interface{}) to ([]interface{}) without going through this workflow.