Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid use of tokLineStart #71

Closed
aparajita opened this issue Oct 8, 2013 · 1 comment
Closed

Invalid use of tokLineStart #71

aparajita opened this issue Oct 8, 2013 · 1 comment

Comments

@aparajita
Copy link
Contributor

In readToken_plus_min, you have the following line of code:

if (next == 45 && input.charCodeAt(tokPos + 2) == 62 && lastEnd < tokLineStart) {

The problem is tokLineStart has no meaning unless options.locations is on, and that check is not being done here. So either you have to always update tokLineStart irrespective of options.locations or find another way to make this test.

@marijnh
Copy link
Member

marijnh commented Oct 10, 2013

Indeed, that was careless. Attached patch should help.

mrcarlberg pushed a commit to mrcarlberg/objj-parser that referenced this issue Jan 13, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants