Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for BigInt (stage 4) #835

Merged
merged 2 commits into from
Jun 5, 2019
Merged

Add support for BigInt (stage 4) #835

merged 2 commits into from
Jun 5, 2019

Conversation

adrianheine
Copy link
Member

See #833.

@mysticatea
Copy link
Contributor

Would you enable Node 10 and 12 in Travis CI?
https://travis-ci.org/acornjs/acorn/builds/541465461 looks to not test the case that BigInt exists.

@marijnh marijnh merged commit 1723094 into master Jun 5, 2019
@marijnh
Copy link
Member

marijnh commented Jun 5, 2019

Looks good to me!

@adrianheine adrianheine deleted the bigint branch June 5, 2019 18:46
@tmcw tmcw mentioned this pull request Jun 14, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@adrianheine @mysticatea @marijnh