Skip to content

Commit c3f798b

Browse files
committed
Improvements for debug output only
Changes to debug print and debug function tracing.
1 parent f8f617f commit c3f798b

File tree

4 files changed

+24
-17
lines changed

4 files changed

+24
-17
lines changed

source/components/disassembler/dmdeferred.c

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -190,7 +190,7 @@ AcpiDmParseDeferredOps (
190190
ACPI_STATUS Status;
191191

192192

193-
ACPI_FUNCTION_ENTRY ();
193+
ACPI_FUNCTION_TRACE (DmParseDeferredOps);
194194

195195

196196
/* Traverse the entire parse tree */
@@ -217,7 +217,7 @@ AcpiDmParseDeferredOps (
217217
Op, Op->Named.Data, Op->Named.Length);
218218
if (ACPI_FAILURE (Status))
219219
{
220-
return (Status);
220+
return_ACPI_STATUS (Status);
221221
}
222222
break;
223223

@@ -245,7 +245,7 @@ AcpiDmParseDeferredOps (
245245
Op = AcpiPsGetDepthNext (Root, Op);
246246
}
247247

248-
return (AE_OK);
248+
return_ACPI_STATUS (AE_OK);
249249
}
250250

251251

source/components/dispatcher/dsargs.c

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -197,7 +197,7 @@ AcpiDsExecuteArguments (
197197
ACPI_WALK_STATE *WalkState;
198198

199199

200-
ACPI_FUNCTION_TRACE (DsExecuteArguments);
200+
ACPI_FUNCTION_TRACE_PTR (DsExecuteArguments, AmlStart);
201201

202202

203203
/* Allocate a new parser op to be the root of the parsed tree */
@@ -474,7 +474,8 @@ AcpiDsGetPackageArguments (
474474
return_ACPI_STATUS (AE_AML_INTERNAL);
475475
}
476476

477-
ACPI_DEBUG_PRINT ((ACPI_DB_EXEC, "Package Arg Init\n"));
477+
ACPI_DEBUG_PRINT ((ACPI_DB_EXEC, "Package Argument Init, AML Ptr: %p\n",
478+
ObjDesc->Package.AmlStart));
478479

479480
/* Execute the AML code for the TermArg arguments */
480481

source/components/dispatcher/dswexec.c

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -723,7 +723,8 @@ AcpiDsExecEndOp (
723723
case AML_TYPE_CREATE_OBJECT:
724724

725725
ACPI_DEBUG_PRINT ((ACPI_DB_EXEC,
726-
"Executing CreateObject (Buffer/Package) Op=%p\n", Op));
726+
"Executing CreateObject (Buffer/Package) Op=%p AMLPtr=%p\n",
727+
Op, Op->Named.Data));
727728

728729
switch (Op->Common.Parent->Common.AmlOpcode)
729730
{

source/components/executer/exdump.c

Lines changed: 16 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -775,12 +775,13 @@ AcpiExDumpOperand (
775775

776776
if (Depth > 0)
777777
{
778-
ACPI_DEBUG_PRINT ((ACPI_DB_EXEC, "%*s[%u] %p ",
779-
Depth, " ", Depth, ObjDesc));
778+
ACPI_DEBUG_PRINT ((ACPI_DB_EXEC, "%*s[%u] %p Refs=%u ",
779+
Depth, " ", Depth, ObjDesc, ObjDesc->Common.ReferenceCount));
780780
}
781781
else
782782
{
783-
ACPI_DEBUG_PRINT ((ACPI_DB_EXEC, "%p ", ObjDesc));
783+
ACPI_DEBUG_PRINT ((ACPI_DB_EXEC, "%p Refs=%u ",
784+
ObjDesc, ObjDesc->Common.ReferenceCount));
784785
}
785786

786787
/* Decode object type */
@@ -818,8 +819,10 @@ AcpiExDumpOperand (
818819

819820
case ACPI_REFCLASS_NAME:
820821

821-
AcpiOsPrintf ("- [%4.4s]\n",
822-
ObjDesc->Reference.Node->Name.Ascii);
822+
AcpiUtRepairName (ObjDesc->Reference.Node->Name.Ascii);
823+
AcpiOsPrintf ("- [%4.4s] (Node %p)\n",
824+
ObjDesc->Reference.Node->Name.Ascii,
825+
ObjDesc->Reference.Node);
823826
break;
824827

825828
case ACPI_REFCLASS_ARG:
@@ -1158,12 +1161,15 @@ AcpiExDumpReferenceObj (
11581161
&RetBuf, TRUE);
11591162
if (ACPI_FAILURE (Status))
11601163
{
1161-
AcpiOsPrintf (" Could not convert name to pathname\n");
1164+
AcpiOsPrintf (" Could not convert name to pathname: %s\n",
1165+
AcpiFormatException (Status));
11621166
}
11631167
else
11641168
{
1165-
AcpiOsPrintf ("%s\n", (char *) RetBuf.Pointer);
1166-
ACPI_FREE (RetBuf.Pointer);
1169+
AcpiOsPrintf ("%s: %s\n",
1170+
AcpiUtGetTypeName (ObjDesc->Reference.Node->Type),
1171+
(char *) RetBuf.Pointer);
1172+
ACPI_FREE (RetBuf.Pointer);
11671173
}
11681174
}
11691175
else if (ObjDesc->Reference.Object)
@@ -1281,9 +1287,8 @@ AcpiExDumpPackageObj (
12811287

12821288
case ACPI_TYPE_LOCAL_REFERENCE:
12831289

1284-
AcpiOsPrintf ("[Object Reference] Type [%s] %2.2X",
1285-
AcpiUtGetReferenceName (ObjDesc),
1286-
ObjDesc->Reference.Class);
1290+
AcpiOsPrintf ("[Object Reference] Class [%s]",
1291+
AcpiUtGetReferenceName (ObjDesc));
12871292
AcpiExDumpReferenceObj (ObjDesc);
12881293
break;
12891294

0 commit comments

Comments
 (0)