You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The main readme point to install acsf-tools either at (a) ~/.drush/ or (b) at the project.
For (b) a change seems to be needed to be compatible with Drupal 9 dependencies.
I will add a related PR against 9.x-dev, since I see that 10.x-dev is still not ready as per #115 (comment) to support both 3.x and 4.x, but that same change may be applied/cherry-picked to other branches too.
The text was updated successfully, but these errors were encountered:
marvil07
added a commit
to marvil07/acsf-tools
that referenced
this issue
Oct 28, 2020
The main readme point to install acsf-tools either at (a)
~/.drush/
or (b) at the project.For (b) a change seems to be needed to be compatible with Drupal 9 dependencies.
The problem:
8.x-dev
,9.x-dev
, and10.x-dev
, depend on symfony/yaml3.x
, e.g. https://github.com/acquia/acsf-tools/blob/10.x-dev/composer.json#L234.x
, e.g. https://git.drupalcode.org/project/drupal/-/blob/9.2.x/core/composer.json#L32This naturally result on not being able to install acsf-tools on a Drupal 9 project.
The best case scenario is to support symfony/yaml in both
3.x
and4.x
versions.I see the use is minimal:
Hence, supporting both should be OK.
There are no breaking changes between those versions, e.g. compare https://github.com/symfony/symfony/blob/3.4/src/Symfony/Component/Yaml/Yaml.php#L80 and https://github.com/symfony/symfony/blob/4.4/src/Symfony/Component/Yaml/Yaml.php#L76
I will add a related PR against 9.x-dev, since I see that 10.x-dev is still not ready as per #115 (comment) to support both
3.x
and4.x
, but that same change may be applied/cherry-picked to other branches too.The text was updated successfully, but these errors were encountered: