Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drupal 9 support #118

Closed
marvil07 opened this issue Oct 28, 2020 · 1 comment
Closed

Drupal 9 support #118

marvil07 opened this issue Oct 28, 2020 · 1 comment

Comments

@marvil07
Copy link

The main readme point to install acsf-tools either at (a) ~/.drush/ or (b) at the project.
For (b) a change seems to be needed to be compatible with Drupal 9 dependencies.

The problem:

This naturally result on not being able to install acsf-tools on a Drupal 9 project.

The best case scenario is to support symfony/yaml in both 3.x and 4.x versions.

I see the use is minimal:

$ git grep Yaml
AcsfToolsUtils.php:use Symfony\Component\Yaml\Yaml;
AcsfToolsUtils.php:    $yaml = Yaml::parse(file_get_contents($path . '/acsf_tools_config.yml'));

Hence, supporting both should be OK.
There are no breaking changes between those versions, e.g. compare https://github.com/symfony/symfony/blob/3.4/src/Symfony/Component/Yaml/Yaml.php#L80 and https://github.com/symfony/symfony/blob/4.4/src/Symfony/Component/Yaml/Yaml.php#L76

I will add a related PR against 9.x-dev, since I see that 10.x-dev is still not ready as per #115 (comment) to support both 3.x and 4.x, but that same change may be applied/cherry-picked to other branches too.

marvil07 added a commit to marvil07/acsf-tools that referenced this issue Oct 28, 2020
The use of it is pretty minimal on the codebase.
sdelbosc added a commit that referenced this issue Jan 5, 2021
#118 Support two symfony/yaml major versions, 3.x and 4.x
@sdelbosc
Copy link
Contributor

sdelbosc commented Jan 5, 2021

Merged this on 9.x with #119 and 10.x with #125

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants