Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DT-602: Reorganize Robo command directories #3735

Closed
danepowell opened this issue Jun 27, 2019 · 1 comment · Fixed by #3919
Closed

DT-602: Reorganize Robo command directories #3735

danepowell opened this issue Jun 27, 2019 · 1 comment · Fixed by #3919

Comments

@danepowell
Copy link
Contributor

danepowell commented Jun 27, 2019

The files containing BLT's Robo command classes are organized in a fairly inscrutable and anachronistic folder hierarchy that has persisted through several reorganizations of the command namespaces themselves.

For instance, the recipes namespace contains commands to intialize ACSF projects, CI projects, or multisite projects, but these are currently scattered among the Acsf, Ci, and Generate directories.

Ideally I think the folder hierarchy would match the command namespace hierarchy. Additionally, commands within each file should be namespaced correctly (for instance the drupal:install command is confusingly defined in BuildCommand.php rather than DrupalCommand.php).

Bonus points for a PHPCS rule or some other validation that enforces this organization going forward.

@mikemadison13
Copy link
Contributor

+1 for this, there are definitely some commands that are impossible to find (and even if you do find them, they don't make a ton of sense where they are).

@danepowell danepowell added this to the Backlog milestone Jun 27, 2019
@danepowell danepowell removed the Chore label Oct 7, 2019
@danepowell danepowell changed the title Reorganize Robo command directories DT-602: Reorganize Robo command directories Nov 14, 2019
danepowell added a commit that referenced this issue Nov 18, 2019
* DT-602: Fixes #3735: Reorganize robo commands and directories.

* Code style cleanup.

* re-add internal commands
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants