-
Notifications
You must be signed in to change notification settings - Fork 396
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DT-602: Reorganize Robo command directories #3735
Comments
+1 for this, there are definitely some commands that are impossible to find (and even if you do find them, they don't make a ton of sense where they are). |
danepowell
changed the title
Reorganize Robo command directories
DT-602: Reorganize Robo command directories
Nov 14, 2019
danepowell
added a commit
to danepowell/blt
that referenced
this issue
Nov 14, 2019
danepowell
added a commit
that referenced
this issue
Nov 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The files containing BLT's Robo command classes are organized in a fairly inscrutable and anachronistic folder hierarchy that has persisted through several reorganizations of the command namespaces themselves.
For instance, the
recipes
namespace contains commands to intialize ACSF projects, CI projects, or multisite projects, but these are currently scattered among theAcsf
,Ci
, andGenerate
directories.Ideally I think the folder hierarchy would match the command namespace hierarchy. Additionally, commands within each file should be namespaced correctly (for instance the
drupal:install
command is confusingly defined in BuildCommand.php rather than DrupalCommand.php).Bonus points for a PHPCS rule or some other validation that enforces this organization going forward.
The text was updated successfully, but these errors were encountered: