Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move system logging config override out of cache.settings.php #3865

Closed
bkosborne opened this issue Oct 1, 2019 · 1 comment · Fixed by #3866
Closed

Move system logging config override out of cache.settings.php #3865

bkosborne opened this issue Oct 1, 2019 · 1 comment · Fixed by #3866
Labels
Enhancement A feature or feature request

Comments

@bkosborne
Copy link
Contributor

Is your feature request related to a problem? Please describe.
BLT's cache.settings.php includes the following:

if (EnvironmentDetector::isProdEnv() || EnvironmentDetector::isStageEnv()) {
  $config['system.logging']['error_level'] = 'hide';
}

This is a strange place for this config override. It has nothing to do with caching.

Describe the solution you'd like
Move this block of code out of cache.settings.php and into logging.settings.php.

Additional context
A few times now I've tried to find where this config override is happening from BLT and cache.settings.php is one of the last places I looked.

@danepowell
Copy link
Contributor

Indeed, that doesn't make much sense. I was trying to figure out how this came to be, apparently it's been like this since the very beginning. Go figure 🙄

danepowell pushed a commit that referenced this issue Oct 4, 2019
#3866)

* Issue #3865: Move location of logging UI override to appropriate file.

* Remove unused use statement

Co-Authored-By: Dane Powell <git@danepowell.com>

* Update cache.settings.php
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement A feature or feature request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants