Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DT-1082: Drupal Coder 8.3.7 doesn't sniff expected files #3957

Closed
danepowell opened this issue Dec 16, 2019 · 0 comments · Fixed by #3962
Closed

DT-1082: Drupal Coder 8.3.7 doesn't sniff expected files #3957

danepowell opened this issue Dec 16, 2019 · 0 comments · Fixed by #3962
Labels
Bug Something isn't working

Comments

@danepowell
Copy link
Contributor

When you update from Drupal Coder 8.3.6 to 8.3.7, it will stop scanning many Drupal-specific files (*.install files, etc...) by default due to this upstream change: https://www.drupal.org/node/3074176

In the short term, users should work around this by adding something like the following to phpcs.xml: <arg name="extensions" value="php,module,inc,install,test,profile,theme,css,info,txt,md,yml"/>
@danepowell danepowell added the Bug Something isn't working label Dec 16, 2019
@danepowell danepowell changed the title Drupal Coder 8.3.7 doesn't sniff certain files DT-1082: Drupal Coder 8.3.7 doesn't sniff certain files Dec 16, 2019
@danepowell danepowell changed the title DT-1082: Drupal Coder 8.3.7 doesn't sniff certain files DT-1082: Drupal Coder 8.3.7 doesn't sniff expected files Dec 17, 2019
danepowell added a commit to danepowell/blt that referenced this issue Dec 17, 2019
@danepowell
DT-1082: Fixes acquia#3957: Fix unexpected PHPCS behavior with Coder …
d6e3807 
…8.3.7.
@danepowell danepowell mentioned this issue Dec 17, 2019
Merged
@danepowell danepowell added this to the Backlog milestone Dec 18, 2019
danepowell added a commit that referenced this issue Dec 25, 2019
@danepowell
DT-1082: Fixes #3957: Fix unexpected PHPCS behavior with Coder 8.3.7. (…
a8b0aa0 
…#3962)
danepowell added a commit that referenced this issue Dec 25, 2019
@danepowell
DT-1082: Fixes #3957: Fix unexpected PHPCS behavior with Coder 8.3.7. (…
58c9b4c 
…#3962)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

DT-1082: Fixes #3957: Fix unexpected PHPCS behavior with Coder 8.3.7. danepowell/blt
1 participant
@danepowell