Detect environment variables correctly with doctor.

[Elaine-dev]

I have my path exported in my bash profile but getting error:
DevDesktop usage is enabled, but $DEVDESKTOP_DRUPAL_SETTINGS_DIR is not set in your environmental variables.

Mac 10.12.6
BLT 11.4.0
Acquia Dev Desktop
Version: 2
Built: Mar 20 2020 04:05:37
Control panel rev: e12e0b8
Stack rev: f721de3

See closed issue: 546

BLT doctor output:

| Property                  | Value                                                        |
+---------------------------+--------------------------------------------------------------+
| %paths.%root              | /Users/chris/Sites/devdesktop/itablt3/docroot                |
| %paths.%site              | sites/itablt3.dd                                             |
| %paths.%modules           | sites/all/modules                                            |
| %paths.%themes            | sites/all/themes                                             |
| %paths.%config-sync       | /Users/chris/Sites/devdesktop/itablt3/config/default         |
| %paths.%config-active     | sites/default/files/config_acqTmp-2020-04-06T10.41.47-8091/a |
|                           | ctive                                                        |
| %paths.%config-staging    | sites/default/files/config_acqTmp-2020-04-06T10.41.47-8091/s |
|                           | taging                                                       |
| %paths.%files             | sites/itablt3.dd/files                                       |
| %paths.%temp              | /tmp                                                         |
| %paths.%private           | /Users/chris/Sites/devdesktop/itablt3/files-private/default  |
| admin-theme               | claro                                                        |
| alias-searchpaths.0       | /Users/chris/Sites/devdesktop/itablt3/drush/sites            |
| base-profile              |                                                              |
| blt-version               | 11.4.0                                                       |
| bootstrap                 | Successful                                                   |
| composer-version          | Composer version 1.10.1 2020-03-13 20:34:27                  |
| config-sync               | /Users/chris/Sites/devdesktop/itablt3/config/default         |
| db-driver                 | mysql                                                        |
| db-hostname               | 127.0.0.1                                                    |
| db-name                   | itablt3                                                      |
| db-password               |                                                              |
| db-port                   | 3306                                                         |
| db-status                 | Connected                                                    |
| db-username               | drupaluser                                                   |
| drupal-settings-file      | sites/itablt3.dd/settings.php                                |
| drupal-version            | 8.8.5                                                        |
| drush-cache-directory     | /Users/chris/.drush/cache                                    |
| drush-conf.0              | /Users/chris/.drush/drush.yml                                |
| drush-conf.1              | /Users/chris/Sites/devdesktop/itablt3/vendor/drush/drush/dru |
|                           | sh.yml                                                       |
| drush-conf.2              | /Users/chris/Sites/devdesktop/itablt3/drush/drush.yml        |
| drush-conf.3              | /Users/chris/Sites/devdesktop/itablt3/docroot/sites/default/ |
|                           | local.drush.yml                                              |
| drush-script              | /Users/chris/Sites/devdesktop/itablt3/vendor/drush/drush/dru |
|                           | sh                                                           |
| drush-temp                | /tmp                                                         |
| drush-version             | 10.2.2                                                       |
| files                     | sites/itablt3.dd/files                                       |
| install-profile           | lightning                                                    |
| modules                   | sites/all/modules                                            |
| php-bin                   | /usr/local/Cellar/php@7.3/7.3.16/bin/php                     |
| php-conf.0                | /usr/local/etc/php/7.3/php.ini                               |
| php-os                    | Darwin                                                       |
| private                   | /Users/chris/Sites/devdesktop/itablt3/files-private/default  |
| root                      | /Users/chris/Sites/devdesktop/itablt3/docroot                |
| site                      | sites/itablt3.dd                                             |
| stacks.drupal-vm.inited   | false                                                        |
| stacks.dev-desktop.inited | DDSETTINGS>                                                  |
|                           | // Please don't edit anything between <DDSETTINGS> tags.     |
|                           | // This section is autogenerated by Acquia Dev Desktop.      |
|                           | if (isset($_SERVER['DEVDESKTOP_DRUPAL_SETTINGS_DIR']) &&     |
|                           | file_exists($_SERVER['DEVDESKTOP_DRUPAL_SETTINGS_DIR'] .     |
|                           | '/loc_itablt3_dd.inc')) {                                    |
|                           |   require $_SERVER['DEVDESKTOP_DRUPAL_SETTINGS_DIR'] .       |
|                           | '/loc_itablt3_dd.inc';                                       |
|                           | }                                                            |
|                           | // </DDSETTINGS>                                             |
|                           |                                                              |
| temp                      | /tmp                                                         |
| theme                     | bartik                                                       |
| themes                    | sites/all/themes                                             |
| uri                       | http://itablt3.dd                                            |
+---------------------------+--------------------------------------------------------------+
[debug] Verifying that Drupal is installed...
[Robo\Common\ProcessExecutor] Running /Users/chris/Sites/devdesktop/itablt3/vendor/bin/drush @self --uri= status bootstrap in /Users/chris/Sites/devdesktop/itablt3/docroot
 Drupal bootstrap : Successful 
+--------------------------------------+--------------------------------------------------------------+
| Check                                | Problem                                                      |
+--------------------------------------+--------------------------------------------------------------+
| DevDesktopCheck:checkDevDesktop      | DevDesktop usage is enabled, but                             |
|                                      | $DEVDESKTOP_DRUPAL_SETTINGS_DIR is not set in your           |
|                                      | environmental variables.                                     |
|                                      |                                                              |
|                                      | Add `export                                                  |
|                                      | DEVDESKTOP_DRUPAL_SETTINGS_DIR="$HOME/.acquia/DevDesktop/Dru |
|                                      | palSettings"` to ~/.bash_profile or equivalent for your      |
|                                      | system.`                                                     |
| NodeCheck:checkNodeVersionFileExists | Neither .nvmrc nor .node-version file found in repo root.    |
+--------------------------------------+--------------------------------------------------------------+

[error] BLT Doctor discovered one or more critical issues.
For troubleshooting guidance and support, see https://docs.acquia.com/blt/support/

[danepowell]

Thanks for reporting, can you please see if this PR fixes your issue: #4119

[Elaine-dev]

Thank you. How do I test? Create a new BLT project?

Created new project, still getting error:

| DevDesktopCheck:checkDevDesktop      | DevDesktop usage is enabled, but                             |
|                                      | $DEVDESKTOP_DRUPAL_SETTINGS_DIR is not set in your           |
|                                      | environmental variables.