Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PIpelines builds fail with "Command validate:all is not defined" #4166

Closed
ba66e77 opened this issue Jun 8, 2020 · 1 comment · Fixed by #4167
Closed

PIpelines builds fail with "Command validate:all is not defined" #4166

ba66e77 opened this issue Jun 8, 2020 · 1 comment · Fixed by #4167
Labels
Bug Something isn't working

Comments

@ba66e77
Copy link
Contributor

ba66e77 commented Jun 8, 2020

Describe the bug
Pipelines builds fail as a result of the validate:all command no longer existing. The same line exists in the Travis file as well, so we'd probably see the same thing there.

To Reproduce
Trigger a Pipelines build using the default acquia-pipelines.yml file, or otherwise invoke the vendor/acquia/blt/scripts/pipelines/validate script.

Expected behavior
The build should only fail because I broke things.

Detailed error output
The Pipelines logs show the error below. Since the

+ source ${BLT_DIR}/scripts/pipelines/validate

export PATH=${COMPOSER_BIN}:${PATH}

blt validate:all --define drush.alias='${drush.aliases.ci}' --ansi --verbose

In Application.php line 669:
                                                                  
  [Symfony\Component\Console\Exception\CommandNotFoundException]  

  Command "validate:all" is not defined.                          
                                                                  
  Did you mean one of these?                                      
      artifact:install:drupal                                     
      drupal:install                                              
      sync:all                                                    
      sync:all:db                                                 
     validate:composer                                           
      validate:php                                                
      validate:twig                                               
      validate:twig:lint:files                                    
      validate:yaml                                               
      validate:yaml:lint:files                                    

System information

  • BLT version: 12.0.0
@ba66e77 ba66e77 added the Bug Something isn't working label Jun 8, 2020
@ba66e77
Copy link
Contributor Author

ba66e77 commented Jun 8, 2020

At a glance, changing the command to validate:all in this line seems reasonable: https://github.com/acquia/blt/blob/12.x/src/Robo/Commands/Validate/ValidateAllCommand.php#L15

However, that throws the validation into an infinite loop where it invokes everything in the namespace, including itself.

Changing the build files to run blt validate .... does seem to work as expected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant