Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support arbitrary config splits and environments #4176

Closed
danepowell opened this issue Jun 10, 2020 · 0 comments · Fixed by #4224
Closed

Support arbitrary config splits and environments #4176

danepowell opened this issue Jun 10, 2020 · 0 comments · Fixed by #4224
Labels
Enhancement A feature or feature request

Comments

@danepowell
Copy link
Contributor

Is your feature request related to a problem? Please describe.
We hardcode the supported config splits, which generally map to environments that we can detect via the EnvironmentDetector. It's a lot of boilerplate code, and people can't easily extend it to add new splits/environments.

Describe the solution you'd like
Add something to EnvironmentDetector to enumerate all "known" environments and whether they are active or not, then build the config split config, and which splits are active, based on whether we are in the respective environment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement A feature or feature request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant