Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow site mail and account mail to be set separately #4261

Closed
kmbremner opened this issue Oct 15, 2020 · 1 comment · Fixed by #4294
Closed

Allow site mail and account mail to be set separately #4261

kmbremner opened this issue Oct 15, 2020 · 1 comment · Fixed by #4294
Labels
Enhancement A feature or feature request

Comments

@kmbremner
Copy link
Contributor

Is your feature request related to a problem? Please describe.
Currently BLT uses the same value (drupal.account.mail) for the site-mail and account-mail values:

    /** @var \Acquia\Blt\Robo\Tasks\DrushTask $task */
    $task = $this->taskDrush()
      ->drush("site-install")
      ->arg($this->getConfigValue('project.profile.name'))
      ->rawArg($this->getConfigValue('setup.install-args'))
      ->option('sites-subdir', $this->getConfigValue('site'))
      ->option('site-name', $this->getConfigValue('project.human_name'))
      ->option('site-mail', $this->getConfigValue('drupal.account.mail'))
      ->option('account-name', $username, '=')
      ->option('account-mail', $this->getConfigValue('drupal.account.mail'))
      ->option('locale', $this->getConfigValue('drupal.locale'))
      ->verbose(TRUE)
      ->printOutput(TRUE);

We don't always want the site email to be the same as the admin user's email.

Describe the solution you'd like
Make it possible to specify separate values for site-mail and account-mail.

Describe alternatives you've considered
It's easy to manually change values after site install and capture in config.

Additional context
Add any other context or screenshots about the feature request here.

@kmbremner kmbremner added the Enhancement A feature or feature request label Oct 15, 2020
@danepowell
Copy link
Contributor

Sounds like a fine feature as long as it's backwards compatible (the new config parameter should default to the value of drupal.account.mail). Should be a pretty straightforward PR if you're interested in contributing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement A feature or feature request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants