Add Twig syntax check to Git pre-commit hook

[TravisCarden]

Symfony2 provides a console command for syntax checking Twig templates:

# You can check by filename:
$ php bin/console lint:twig app/Resources/views/article/recent_list.html.twig

# or by directory:
$ php bin/console lint:twig app/Resources/views

We should consider adding this check to the Git pre-commit hook (and anywhere else we do linting).

[grasmash]

Yay! I've been wanting to add this but I didn't know what tool would provide the linting.

[grasmash]

@TravisCarden I don't appear to have a vendor/bin/console despite having symfony/console as a dependency. What package version are you using?

[TravisCarden]

lint:twig is documented under the Templating component (symfony/templating). Perhaps it's provided separately by that? (I never implemented this. I just saw it in the documentation.)

[grasmash]

Hm. Having trouble getting that binary to show up in the bin directory. Tried requiring both symfony/templating and symfony/console.

I wonder if we need to create a custom app and register those commands. It seems like that shouldn't be necessary.

[grasmash]

Looks like this is part of symfony/symfony and is registered in https://github.com/symfony/symfony/blob/2.8/src/Symfony/Bridge/Twig/Command/LintCommand.php.

Maybe we should look at a lighter-weight solution like https://github.com/asm89/twig-lint.

[grasmash]

So, lots of Symfony learning. Firstly, Symfony has a nightly build process that creates separate packagist projects for each component via git subtree. The lint command is part of symfony/twig-bridge.

The lint command can be registered with our own blt-console bin in one of two ways:

• We can convert blt-console to a full fledged Symfony app and register the twig-bridge bundle in a custom AppKernel, see https://github.com/grasmash/bolt/tree/issue-44-twig-app. This is pretty heavy weight but lets use quickly register new bundles easily.
• Leave blt-console as a standalone bundle and simple register the lint command (alone) in blt-console. See https://github.com/grasmash/bolt/tree/issue-44-add-lint-twig

[grasmash]

Command was added but is not yet being executed in pre-commit hook.

[grasmash]

Command currently exists in blt, ./vendor/bin/blt-console twig:lint --help